Date: Wed, 10 Sep 2014 02:26:26 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 181301] [NEW PORT] net/kamailio: Very fast and configurable open source SIP proxy Message-ID: <bug-181301-13-J740BTxMCK@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-181301-13@https.bugs.freebsd.org/bugzilla/> References: <bug-181301-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D181301 --- Comment #13 from olivermahmoudi@gmail.com --- (In reply to John Marino from comment #11) > (In reply to olivermahmoudi from comment #10) >=20 > > 5) XPLIST_SUB+=3D MYSQL=3D"" > > X.else > > XPLIST_SUB+=3D MYSQL=3D"@comment " > >=20 > > This is ancient use of options, use the new OPTIONS_SUB please (review > > porters handbook on OPTIONS) > >=20 > > The program's configure stage is non standard and options are passed on= a > > pre-build stage to prepare the built. Checked back on this issued with = the > > ports mailing list. Their feedback was that it is still OK to keep it t= hat=20 > > way since the new way of setting up the options won't solve my special > > scenario here. >=20 > Well, except OPTIONS_SUB affects PLIST_SUB and not configure arguments. I > was objecting to your (ancient) brute force definitions of "" and "@comme= nt > " which is unnecessary with OPTIONS_SUB If what you are talking about is this: ### Version 1=20 .if ${PORT_OPTIONS:MMYSQL} BUILD_DEPENDS+=3D ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server RUN_DEPENDS+:=3D ${BUILD_DEPENDS} EXTRA_MODULES+=3D db_mysql PLIST_SUB+=3D MYSQL=3D"" .else PLIST_SUB+=3D MYSQL=3D"@comment " .endif ### Version 2 OPTIONS_SUB=3Dyes .if ${PORT_OPTIONS:MMYSQL} BUILD_DEPENDS+=3D ${LOCALBASE}/libexec/mysqld:${PORTSDIR}/databases/mysql56-server RUN_DEPENDS+:=3D ${BUILD_DEPENDS} EXTRA_MODULES+=3D db_mysql .endif whereas: Version 1 =3D=3D Version 2 then I can see what you mean and could update things to Version 2 via OPTIONS_SUB. What I would essentially be carving out is this bit: PLIST_SUB+=3D MYSQL=3D"" .else PLIST_SUB+=3D MYSQL=3D"@comment " and it would still work. Is this the point you were trying to make? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-181301-13-J740BTxMCK>