Date: Sun, 15 Dec 1996 19:50:23 +0800 From: Peter Wemm <peter@spinner.DIALix.COM> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-all@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-sys@freefall.freebsd.org, nate@mt.sri.com Subject: Re: cvs commit: src/sys/i386/boot/rawboot Makefile Message-ID: <199612151150.TAA20129@spinner.DIALix.COM> In-Reply-To: Your message of "Sun, 15 Dec 1996 22:26:19 %2B1100." <199612151126.WAA01931@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans wrote: > >Well, you're welcome to fix i386/boot/biosboot/probe_keyboard.c then and > >the Makefiles that have to give the -I paths. > > I've already removed (broken) -I paths from biosboot/Makefile once :-). > It would have saved time to put the right things in the headers and put > the headers in the right place to begin with. My complaint is that they are hidden under i386/isa/ic/* making access to them rather difficult. There is nothing isa-specific about the i8042.h file, except the two IO port control/data addresses (which are duplicated from isa.h). IMHO, the "chip defines" should have gone under i386/include/ic so they could be accessable as #include <machine/ic/i8042.h> without having to obsuscate the code with -I paths or bogus #include lines. > Many keyboard #defines, not to mention code, are also duplicated > (with different names and one different value) in biosboot/io.c and > netboot/misc.c :-(. This would not suprise me in the least... :-/ > Bruce Cheers, -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612151150.TAA20129>