Date: Fri, 4 Apr 2014 12:59:07 +0100 From: David Chisnall <theraven@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r264042 - in head: include lib/libc/gen lib/libc/include lib/libc/stdlib Message-ID: <F2A33EA8-14F2-4D62-9021-9023A1751E48@FreeBSD.org> In-Reply-To: <20140404115256.GA85137@ivaldir.etoilebsd.net> References: <201404021607.s32G7mhw051355@svn.freebsd.org> <20140404115256.GA85137@ivaldir.etoilebsd.net>
index | next in thread | previous in thread | raw e-mail
On 4 Apr 2014, at 12:52, Baptiste Daroussin <bapt@FreeBSD.org> wrote: > On Wed, Apr 02, 2014 at 04:07:48PM +0000, David Chisnall wrote: >> Author: theraven >> Date: Wed Apr 2 16:07:48 2014 >> New Revision: 264042 >> URL: http://svnweb.freebsd.org/changeset/base/264042 >> >> Log: >> Add support for some block functions that come from OS X. These are >> intended to build with any C compiler. >> >> Reviewed by: pfg >> MFC after: 3 weeks > > This breaks a couple of ports starting with cups, those ports do expect > libdispatch to be available if _BLOCK_ exists. Do you plan to import > libdispatch soon? __BLOCKS__ is a compiler predefine, which this doesn't change - it just exposes some other functions *if* __BLOCKS__ is defined. I'm not sure what _BLOCK_ is - is it something that their configure script is defining? We do currently have some inconsistency in the base system, because gcc defaults to -fblocks, whereas clang defaults to -fno-blocks on FreeBSD. This means that __BLOCKS__ is defined when building with gcc from base, but with clang from base or gcc from ports, but that's independent of this change. I believe that libdispatch most likely won't be imported until there is an in-tree consumer, but it's in ports and there's nothing stopping ports depending on it if they want to use it... Davidhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F2A33EA8-14F2-4D62-9021-9023A1751E48>