Date: Fri, 25 Sep 2015 22:11:34 -0700 From: NGie Cooper <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r288241 - head/share/mk Message-ID: <CAGHfRMArxy3hQHpWv0ZjZandmafugFhv9%2Bd7Ry2kAg68v%2B1Oaw@mail.gmail.com> In-Reply-To: <5605D4FC.4040205@FreeBSD.org> References: <201509252303.t8PN3Wx0098623@repo.freebsd.org> <CAGHfRMAJvFuWQSGAMYd3wq0MTXTZuvn6cTzzYhP2rM=9M7caWQ@mail.gmail.com> <5605D4FC.4040205@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 25, 2015 at 4:13 PM, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 9/25/2015 4:12 PM, NGie Cooper wrote: >> On Fri, Sep 25, 2015 at 4:03 PM, Bryan Drewery <bdrewery@freebsd.org> wrote: >>> Author: bdrewery >>> Date: Fri Sep 25 23:03:32 2015 >>> New Revision: 288241 >>> URL: https://svnweb.freebsd.org/changeset/base/288241 >>> >>> Log: >>> Remove 'set -e' that are no longer needed as it is already default. >>> >>> When bmake was initially imported at r241298 shell commands were no longer >>> ran with 'set -e' as they were before. This was fixed in r254980 so they >>> again always use 'set -e'. >> >> The bsd.subdir.mk portion of the change looks like it would cause >> issues depending on what's being called (fmake or an earlier version >> of sys.mk might be used at install time). >> > > We only support bmake in head. And the 'set -e' were only added for > bmake compatibility before it was fixed to work like fmake did. Sorry. Fuzzy memory on the latter item. Yeah, I requested it a couple years ago. We might only support bmake in head, but there's nothing preventing someone from doing a source upgrade from one of the older 10 releases to 11+. Thinking about this a bit more, this is an extreme edge case that doesn't really matter, because people doing source upgrades across major releases really should be doing them from the latest minor release for the major release.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGHfRMArxy3hQHpWv0ZjZandmafugFhv9%2Bd7Ry2kAg68v%2B1Oaw>