Date: Thu, 28 Feb 2019 13:44:31 -0800 From: Enji Cooper <yaneurabeya@gmail.com> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344666 - head/tools/build/mk Message-ID: <0EC04D65-721E-49F1-9755-7A8FDDE554DB@gmail.com> In-Reply-To: <201902282048.x1SKmILE082786@repo.freebsd.org> References: <201902282048.x1SKmILE082786@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Feb 28, 2019, at 12:48 PM, Bryan Drewery <bdrewery@FreeBSD.org> = wrote: >=20 > Author: bdrewery > Date: Thu Feb 28 20:48:18 2019 > New Revision: 344666 > URL: https://svnweb.freebsd.org/changeset/base/344666 >=20 > Log: > bsd.nls.mk isn't optional. >=20 > It is protected by MK_NLS. If it should really be optional then > it needs to be documented as such in share/mk/bsd.README and > .sinclude used where needed. >=20 > This fixes a regression from r335011. >=20 > PR: 232527 > Submitted by: jarrod@downtools.com.au > Reported by: ktullavik@gmail.com > MFC after: 3 days Should bsd.{lib,prog}.mk instead be taught to ignore errors when = including this file? Thanks! -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0EC04D65-721E-49F1-9755-7A8FDDE554DB>