Date: Thu, 16 Apr 2009 14:30:05 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Andriy Gapon <avg@icyb.net.ua> Cc: freebsd-multimedia@FreeBSD.org, Rui, Paulo <rpaulo@FreeBSD.org>, "M. Warner Losh" <imp@bsdimp.com>, John Baldwin <jhb@FreeBSD.org> Subject: Re: strict signatures for kobj methods in sound subsystem Message-ID: <20090416143005.74393on2jzdlbts0@webmail.leidinger.net> In-Reply-To: <49E62215.4010309@icyb.net.ua> References: <49E62215.4010309@icyb.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Andriy Gapon <avg@icyb.net.ua> (from Wed, 15 Apr 2009 21:06:13 +0300): > > Please review the attached, largely mechanical, patch for sound subsystem. > This patch is supposed to make all functions that implement kobj methods have > strictly the same signatures as defined by the interfaces. As you have to change a lot of places, a question would be if it is ok to change the interface from u_int32_t to int instead. I haven't investigated if this is about our internal in-kernel interface, or (indirectly) the official userland OSS interface. I also hadn't a look what 3rd party sound drivers (e.g. in ports) are using. You are also mixing u_int32_t and uint32_t in the change. Most of them are of the u_int32_t style, but some changes have uint32_t. Bye, Alexander. -- Bigamy is having one spouse too many. Monogamy is the same. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090416143005.74393on2jzdlbts0>