Date: Sun, 6 Apr 2008 16:55:56 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: Brooks Davis <brooks@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d ppp src/share/man/man5 rc.conf.5 Message-ID: <20080406165513.N66744@maildrop.int.zabbadoz.net> In-Reply-To: <200803280757.m2S7vqvN037009@repoman.freebsd.org> References: <200803280757.m2S7vqvN037009@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 28 Mar 2008, Brooks Davis wrote:
> brooks 2008-03-28 07:57:52 UTC
>
> FreeBSD src repository
>
> Modified files:
> etc/rc.d ppp
> share/man/man5 rc.conf.5
> Log:
> Add support for hardwiring ppp sessions to particular devices with new
> per-profile variables of the form ppp_<profile>_unit. No ppp_unit
> variable is supported since tying the same unit to more than one profile
> won't work.
>
> PR: conf/122127
> MFC after: 1 week
There is a bug in there:
+ # Check for hard wired unit
+ eval _ppp_unit=\$ppp_${_ppp_profile_cleaned}_unit
+ if [ -n "_ppp_unit" ]; then
^^^^^^^^^^^ should ${_ppp_unit}
+ _ppp_unit="-unit${_ppp_unit}"
+ fi
+ rc_flags="$rc_flags $_ppp_unit"
> Revision Changes Path
> 1.18 +8 -1 src/etc/rc.d/ppp
> 1.337 +9 -1 src/share/man/man5/rc.conf.5
--
Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Software is harder than hardware so better get it right the first time.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080406165513.N66744>