Date: Wed, 29 Apr 2015 10:23:04 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: Lars Engels <lme@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@FreeBSD.ORG, shadowbq@gmail.com Subject: Re: svn commit: r384872 - in head/security: . passivedns passivedns/files Message-ID: <5540F758.2030605@FreeBSD.org> In-Reply-To: <y4lc-vynn-wny@FreeBSD.org> References: <201504272033.t3RKXcGl079169@svn.freebsd.org> <553FD751.6060408@FreeBSD.org> <y4lc-vynn-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--P6oNouVf0tRrgJuoKgaTwKEhnb7mMBCAl
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
On 4/28/2015 2:30 PM, Jan Beich wrote:
> Bryan Drewery <bdrewery@FreeBSD.org> writes:
>=20
>> On 4/27/2015 3:33 PM, Lars Engels wrote:
>>
>>> +DISTVERSION=3D ${GH_TAG}
>> [...]
>>> +GH_TAG=3D a6c7e26
>>
>> Actually this is not valid either. As soon as a new commit is done the=
>> port may "go backwards".
>=20
>> Commit hashses are not valid versions. Dates are.
>=20
> git describe --tags output is no worse than appending svn revision to
> the nearest tag. DISTFILES was already partially correct.
>=20
> $ pkg version -t 1.1.3 1.1.3-60
> <
>=20
>> A PORTEPOCH bump will be needed as well after fixing this.
>=20
> Not really. bsd.port.mk assumes any letter as a pre-release suffix.
>=20
> # PORTVERSION=3Da6c7e26
> $ pkg version -t a6c7e26 0
> <
>=20
> # DISTVERSION=3Da6c7e26
> $ pkg version -t a6.c7.e26 0
> <
No. The next hash could start with 'f' and the one after 'a'. Git hashes
are not monotonically increasing.
--=20
Regards,
Bryan Drewery
--P6oNouVf0tRrgJuoKgaTwKEhnb7mMBCAl
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJVQPdYAAoJEDXXcbtuRpfPo6gIAIcx5xuztynFj6MFJPbd0VCP
grEnUx5op82MIdw18ILATaeNlZlr/sBI7oE04eh0QrJWtLs3iJSs3FPAVZY/j6Uk
meHZzQIGBFcHM6jdbtJ+mR5Z/KvxeeAvAyql0eblHaaw0LmYlsbzxsdp9sS6ny9R
I4blL2EWN2MuR65TkRUP+xWkLVibrLNeWkTwbNGWmNeLgE9PD/HNBJAM+ptRsAsu
epd1P5+oPD5tA5wtJVJMKCj3DJVVqVc2Xi/Hlbovzq6YzSAJ3mOu2p0eRn7C9ZmU
IHyQWfuS+T/ZDlL0r1kRsxIwdXMrRfD2YpYx8EjMhaDwFnec7lz61XELc+2N4gg=
=a3ah
-----END PGP SIGNATURE-----
--P6oNouVf0tRrgJuoKgaTwKEhnb7mMBCAl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5540F758.2030605>