Date: Mon, 15 May 1995 17:23:50 +0400 (MSD) From: "Andrey A. Chernov, Black Mage" <ache@astral.msk.su> To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>, Kai Vorma <vode@freud.hut.fi> Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com, nate@trout.sri.MT.net Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c Message-ID: <vCcNrjluZ2@astral.msk.su> In-Reply-To: <199505150731.AAA05385@gndrsh.aac.dev.com>; from "Rodney W. Grimes" at Mon, 15 May 1995 00:31:18 -0700 (PDT) References: <199505150731.AAA05385@gndrsh.aac.dev.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <199505150731.AAA05385@gndrsh.aac.dev.com> Rodney W. Grimes
writes:
>>
>>
>>
>> On Sun, 14 May 1995, Nate Williams wrote:
>>
>> > Andrey A. Chernov writes:
>> > > ache 95/05/14 17:03:33
>> > >
>> > > Modified: usr.bin/rpcgen rpc_parse.c
>> > > Log:
>> > > End of listcan be not marked, fix it
>> > > Submitted by: Kai Vorma <vode@snakemail.hut.fi>
>> >
>> > I looked at this fix, and I'm not sure that the proposed 'fix' was
>> > necessary. Did you look at the fix at determine if it was indeed needed?
>>
>> Without this fix the last plist->next link is uninitialized. rpcgen
>> still works, because the way BSD malloc works (it cannot reuse freed
>> memory so it asks more from the system and that memory is zeroed ->
>> next-link happens to be NULL).
>>
>> I have replaced the system malloc with a better one and rpcgen
>> dumps core without this patch.
>Then this is not a critical bug fix, becuase as ship freebsd does not
>have the bug!
It have, but this bag is masked with other things (side effect of malloc).
You follow bad way Rod: I remember in some days we have two bugs:
one in syscons and one in termcap which masked each other and complex
variant do right things, according to your way we don't need to fix
them.
>Are you *absolutely* sure your change has no side effects that would
>cause something else to break? If so I can live with this change,
>if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c
>and obsolete this last change until after the release is done.
Rod, did you even saw whole code? I think that any one year C
programmer can easily understand what happens there with and
without this patch.
--
Andrey A. Chernov : And I rest so composedly, /Now, in my bed,
ache@astral.msk.su : That any beholder /Might fancy me dead -
FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead.
RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?vCcNrjluZ2>