Date: Fri, 9 Sep 1994 11:13:51 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: paul@isl.cf.ac.uk (Paul Richards) Cc: paul@freefall.cdrom.com, ache@freefall.cdrom.com, adam@freefall.cdrom.com, alm@freefall.cdrom.com, ats@freefall.cdrom.com, bde@freefall.cdrom.com, csgr@freefall.cdrom.com, cvs-libexec@freefall.cdrom.com, davidg@freefall.cdrom.com, dfr@freefall.cdrom.com, dyson@freefall.cdrom.com, gclarkii@freefall.cdrom.com, gpalmer@freefall.cdrom.com, guido@freefall.cdrom.com, hsu@freefall.cdrom.com, jkh@freefall.cdrom.com, joerg@freefall.cdrom.com, julian@freefall.cdrom.com, jvh@freefall.cdrom.com, karl@freefall.cdrom.com, martin@freefall.cdrom.com, nate@freefall.cdrom.com, phk@freefall.cdrom.com, proven@freefall.cdrom.com, pst@freefall.cdrom.com, rgrimes@freefall.cdrom.com, rich@freefall.cdrom.com, se@freefall.cdrom.com, sean@freefall.cdrom.com, sef@freefall.cdrom.com, smace@freefall.cdrom.com, sos@freefall.cdrom.com, torstenb@freefall.cdrom.com, wollman@freefall.cdrom.com Subject: Re: cvs commit: src/libexec Makefile Message-ID: <199409091813.LAA11979@gndrsh.aac.dev.com> In-Reply-To: <199409091755.SAA06000@isl-gate.elsy.cf.ac.uk> from "Paul Richards" at Sep 9, 94 06:55:51 pm
next in thread | previous in thread | raw e-mail | index | archive | help
>
> In reply to Rodney W. Grimes who said
> >
> > I am not picking on paul here, even I was guilty of it this last night
> > in my rush to get some things done... but we need to clean this act up,
> > the log files are getting cluttered to death, and no one is getting
> > reviews :-(.
>
> I think you picked a particularly bad example since I comply with ALL the
> requirements here.
Nope, again ``Delete the ``Submitted by'' line if this is NOT somebody else's
work''. This was NOT some elses work, YOU may the decision to delete it,
thus you are the author of this change, thus there should be no submitted by:
line. We know who submitted it in this case by the person that commited it.
> > > paul 94/09/09 09:40:29
> > ^^^^^^
> > >
> > > Modified: libexec Makefile
> > > Log:
> > > Removed bugfiler.
> > > Submitted by: Paul Richards
> > ^^^^^^^^^^^^
>
> >
> >
> > Reviewed by:
> > Submitted by:
> > CVS: ----------------------------------------------------------------------
> > CVS: Delete the ``Reviewed by'' line if this is somebody else's work
> > CVS: (you are the reviewer).
> > CVS: Delete the ``Submitted by'' line if this is NOT somebody else's
> > ^^^^^^^^^^^^^^
> > CVS: work (you are the author).
>
> The above comments just don't make sense. The reviewed by line should
> be deleted if this is NOT somebody else's work. If it IS somebody else's
> work then you are the reviewer. The submitted line should never be deleted.
> It should always be the originator of the code whether yourself or someone
> who sent it to you for review.
No, if the work is someone elses they are the submitter, YOU are the
reviewer, inwich case you only need the Submitted line:, when know from
the commit originator that you reviewed this before committing it.
I will agree the english in rcstemplate could be made to read better if
a few of the negatives where removed.
> > If the changes are insubstantial and noncontroversial (e.g., fixing
> > spelling errors, or most Makefile changes) there is no need for
> > review. Please delete the ``Reviewed by:'' line, though, so that the
> > logs look cleaner.
>
> This is the relevant paragraph for the above commit, what did I do wrong?
You did that paragraph correctly, you failed to follow the next one though:
If you are committing code or modifications which were originally done
by some other person or group, them please please please make sure to
credit them in the ``Submitted by'' line. In this case, you are
considered to be the reviewer. If it is your own code, or that of
^^^^^^^^^^^^^^
another team member, then you should delete the ``Submitted by'' line,
so that the logs look cleaner.
The ^^^ above should really read ``your own code, or modification''.
The whole idea of these is that we have been pretty relaxed about having
others look at our work before commiting it. Well, 5 of my last 10 commits
where cleaning up where others had failed to do an adaquate job. This is
not productive, and it is one of the issues that almost drove me to go do
my own thing... and may do that yet.
Now, onto another thing about this particual commit and why a review should
have been done. You set up gnats, great, wonderfull THANKS!! But no one,
nata, zippo, in -core, or else where has ever even done a test filling of
a bug report. Nor is it currently possible for anyone to have a working
send-pr even on a system build 4 hours ago from -current.
Currently send-pr is going to fail install on anyones box who enables it
in gnu/usr.bin/Makefile (or did you do that alread):
skyrsh:rgrimes {116} make install
install -c -o bin -g bin -m 555 /usr/src/gnu/usr.bin/send-pr/send-pr /usr/bin/send-pr
install: /usr/src/gnu/usr.bin/send-pr/send-pr: No such file or directory
*** Error code 1
Stop.
skyrsh:rgrimes {117}
It needs an update to etc/mtree before it can install.
The previos user base does have some knowledge of and occasionally does use
the old bugfiller. In 2.0 this is now just going to dis appear with no
pointer to the new tool. I suggest you add a MLINKS= bugfiler send-pr or
is that send-pr bugfiler.
If you had submitted this change for review, these facts would have been
uncovered before the commit and possible have saved me the above debug.
Nough said.
> --
> Paul Richards, FreeBSD core team member.
> Intelligent Systems Laboratory, ELSYM ,University of Wales, College Cardiff
> Internet: paul@isl.cf.ac.uk, JANET(UK): RICHARDSDP@CARDIFF.AC.UK
>
--
Rod Grimes rgrimes@gndrsh.aac.dev.com
Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199409091813.LAA11979>