Date: Sat, 15 Nov 2025 21:00:10 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a615ded5bf2d - main - sys/conf/files: Add iwx driver Message-ID: <975p35no-15n8-q8o8-r154-r3517o4o6oqs@mnoonqbm.arg> In-Reply-To: <202511150319.5AF3JZxn087193@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On Sat, 15 Nov 2025, Dag-Erling Smørgrav wrote: > The branch main has been updated by des: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a615ded5bf2dd7f563eed6766d32fc063ae36f92 > > commit a615ded5bf2dd7f563eed6766d32fc063ae36f92 > Author: Dag-Erling Smørgrav <des@FreeBSD.org> > AuthorDate: 2025-11-15 03:18:45 +0000 > Commit: Dag-Erling Smørgrav <des@FreeBSD.org> > CommitDate: 2025-11-15 03:18:45 +0000 > > sys/conf/files: Add iwx driver > > PR: 290812 > Fixes: 2ad0f7e91582 ("Import iwx as ported from OpenBSD by Future Crew.") > Reviewed by: emaste > Differential Revision: https://reviews.freebsd.org/D53758 > --- > sys/conf/files | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sys/conf/files b/sys/conf/files > index 87c8830b192e..53fcb80f2b8d 100644 > --- a/sys/conf/files > +++ b/sys/conf/files > @@ -2278,6 +2278,10 @@ iwn6050.fw optional iwn6050fw | iwnfw \ > compile-with "${NORMAL_FW}" \ > no-obj no-implicit-rule \ > clean "iwn6050.fw" > +dev/iwx/if_iwx.c optional iwx \ > + compile-with "${NORMAL_C} -DIWX_DEBUG=1" > +dev/iwx/if_iwx_debug.c optional iwx \ > + compile-with "${NORMAL_C} -DIWX_DEBUG=1" > dev/ixgbe/if_ix.c optional ix inet \ > compile-with "${NORMAL_C} -I$S/dev/ixgbe -DSMP" > dev/ixgbe/if_ixv.c optional ixv inet \ Why would we add the debug flag in a default kernel compile? Should that the not be enabled in the driver code based on DBEUG or IEEE80211_DEBUG or like for other drivers be an option? For exmaple, we do have RTWN_DEBUG, ATH_DEBUG*, BWI_DEBUG*, BWN_DEBUG, MALO_DEBUG, MWL_DEBUG, IWM_DEBUG, IWN_DEBUG, WPI_DEBUG for various wireless drivers. I don't see what iwx should be special? -- Bjoern A. Zeeb r15:7home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?975p35no-15n8-q8o8-r154-r3517o4o6oqs>