Date: Sat, 3 Mar 2001 10:31:00 +0200 (EET) From: Maxim Sobolev <sobomax@FreeBSD.org> To: sobomax@FreeBSD.org (Maxim Sobolev) Cc: kris@FreeBSD.org (Kris Kennaway), cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: ports/audio/mpg123 Makefile ports/audio/mpg123/files Message-ID: <200103030831.f238V1W69229@vic.sabbo.net> In-Reply-To: <200103030821.f238Lgf69187@vic.sabbo.net> from "Maxim Sobolev" at Mar 03, 2001 10:21:16 AM
next in thread | previous in thread | raw e-mail | index | archive | help
> > > > > kris 2001/03/02 16:23:13 PST > > > > Modified files: > > audio/mpg123 Makefile > > audio/mpg123/files patch-ab > > Added files: > > audio/mpg123/files patch-ae > > Log: > > Switch the ASM selection code to use CPUTYPE on -current, and hence > > automatically select the correct version without needing to set a > > non-standard environment variable. > > Use random() instead of rand() because I'm sick of getting the same songs > > over and over in shuffle play. > > Quell a format string warning with -Wnon-const-format > > Bump PORTREVISION > > > > Reviewed by: maintainer timeout > ^^^^^^^^^^^^^^^^^^ > It is not true, because: > 1. You did not send me random() vs. rand() changes at all; > 2. The same is about -Wnon-const-format; > 3. About your CPUTYPE request I replied you that this makes impossible to > use ASM optimisation on anything but very recent -stable and -current. > AFAIK, ports expected to work at least on wide range of systems > between 4.0-RELEASE and pre-CPUTYPE 4-STABLE; > 4. In addition you broke the port (<bsd.port.pre.mk> instead of > <bsd.port.mk>): OOPS, sorry I'm now completely woke up, plese ignore (3) and <bsd.port.pre.mk> vs. <bsd.port.mk> in (4). But the truth is that the port is broken on 4-STABLE. Please fix and next time avoid controversal "maintainer timeout" without sufficient reasons. -Maxim > > /usr/ports/audio/mpg123# make > If you want to compile with ESound support, > hit Ctrl-C right now and use "make WITH_ESOUND=yes" > If you want to compile with NAS support, > hit Ctrl-C right now and use "make WITH_NAS=yes" > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > Syntax error: Unterminated quoted string > *** Error code 2 > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200103030831.f238V1W69229>