Date: Tue, 7 Jul 1998 15:37:58 +1000 From: Bruce Evans <bde@zeta.org.au> To: current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci pcisupport.c Message-ID: <199807070537.PAA05836@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
> Modified files: > sys/pci pcisupport.c > Log: > Changed `#if defined(i386)' to `#ifdef __i386__'. > > `#if defined(ONE_THING)' is a style bug, and i386 instead of __i386__ > is a bug, since i386 is never defined when the kernel is compiled > by with the default flags (`gcc -ansi ...'). Here the bug disabled > the call to pmap_setvidram(), so ISA video memory was not mapped > WC on 686's. The bug may have been masked by bugs in the committer's > version of gcc - `gcc -ansi' incorrectly defines i386 for gcc = the > version of egcs on the 2.2.6 cdrom. Hopefully there is no hardware that depends on this bug. Write combining causes problems when it is used on device memory that doesn't look like frame buffer. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199807070537.PAA05836>