Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 Mar 2017 08:07:36 -0800 (PST)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Hans Petter Selasky <hselasky@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r314905 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf modules/linuxkpi
Message-ID:  <201703081607.v28G7a6E001322@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <201703081109.v28B9RCD000618@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ]
> Author: hselasky
> Date: Wed Mar  8 11:09:27 2017
> New Revision: 314905
> URL: https://svnweb.freebsd.org/changeset/base/314905
> 
> Log:
>   Cleanup the LinuxKPI slab implementation.
>   
>   Put large functions into linux_slab.c instead of declaring them static
>   inline.
>   
>   Add support for more memory allocation wrappers like kmalloc_array()
>   and __vmalloc().
>   
>   Make sure either the M_WAITOK or the M_NOWAIT flag is set and mask
>   away unused memory allocation flags before calling FreeBSD's malloc()
>   routine.
>   
>   Move kmalloc_node() definition to slab.h where it belongs.
>   
>   Implement support for the SLAB_DESTROY_BY_RCU feature when creating a
>   kmem_cache which basically means kmem_cache memory is freed using
>   call_rcu().
>   
>   MFC after:		1 week
>   Sponsored by:		Mellanox Technologies
> 
> Added:
>   head/sys/compat/linuxkpi/common/src/linux_slab.c   (contents, props changed)
> Modified:
>   head/sys/compat/linuxkpi/common/include/linux/gfp.h
>   head/sys/compat/linuxkpi/common/include/linux/slab.h
>   head/sys/conf/files
>   head/sys/modules/linuxkpi/Makefile
> 
> Modified: head/sys/compat/linuxkpi/common/include/linux/gfp.h
> ==============================================================================
> --- head/sys/compat/linuxkpi/common/include/linux/gfp.h	Wed Mar  8 09:53:20 2017	(r314904)
> +++ head/sys/compat/linuxkpi/common/include/linux/gfp.h	Wed Mar  8 11:09:27 2017	(r314905)
> @@ -168,8 +168,6 @@ gfpflags_allow_blocking(const gfp_t gfp_
>  	return ((gfp_flags & (M_WAITOK | M_NOWAIT)) == M_WAITOK);
>  }
>  
> -#define kmalloc_node(chunk, mask, node)         kmalloc(chunk, mask)
> -
>  #define	SetPageReserved(page)	do { } while (0)	/* NOP */
>  #define	ClearPageReserved(page)	do { } while (0)	/* NOP */
>  
> 
> Modified: head/sys/compat/linuxkpi/common/include/linux/slab.h
> ==============================================================================
> --- head/sys/compat/linuxkpi/common/include/linux/slab.h	Wed Mar  8 09:53:20 2017	(r314904)
> +++ head/sys/compat/linuxkpi/common/include/linux/slab.h	Wed Mar  8 11:09:27 2017	(r314905)
> @@ -2,7 +2,7 @@
>   * Copyright (c) 2010 Isilon Systems, Inc.
>   * Copyright (c) 2010 iX Systems, Inc.
>   * Copyright (c) 2010 Panasas, Inc.
> - * Copyright (c) 2013, 2014 Mellanox Technologies, Ltd.
> + * Copyright (c) 2013-2017 Mellanox Technologies, Ltd.

Though widly seen, often miss understood, this modification technically under the copyright
law can be used to assert that you have claimed copyright on the 2014 work more than one
year after original poublication, hence the work done in 2014 now falls under different
parts of the US copyright law.  A prefered form of the above dates would be
2013-2014, 2017.  Do not assert copyrights for years in which no new material was
published.   Publishes is defferent than written.  Do not interpret these dates
as the dates written.

Effect of this type of error:
  According to the U.S. Copyright Act, if the year date [in the copyright
  notice] is more than one year later than the year in which publication first
  occurred, the work is considered to have been published without any notice.

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703081607.v28G7a6E001322>