Date: Wed, 9 Jul 2025 21:22:06 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f9cf745a5084 - main - RELNOTES: Document the addition of inotify Message-ID: <CAFDf7UJuJs3j3ZzKAR_1edktXXDC9f-wHzvmh3snW5eqUQsjhQ@mail.gmail.com> In-Reply-To: <aG5hZ6fQ0dZkON6b@nuc> References: <202507041513.564FDwxH011496@gitrepo.freebsd.org> <CAFDf7UJ%2Bk5rEBYv14szUhj9k=aBKC5VBJsjK8XoxuroWGdKoww@mail.gmail.com> <aG5hZ6fQ0dZkON6b@nuc>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hello Mark!
I confirm that it builds OK.
i3 wm depends on it, so I will have a run test in the next days.
Also I will update my main amd64 soon and test it in there too.
Thanks,
Mark Johnston <markj@freebsd.org> escreveu (quarta, 9/07/2025 à(s) 13:32):
> On Wed, Jul 09, 2025 at 01:13:02PM +0100, Nuno Teixeira wrote:
> > Hello,
> >
> > Not sure if related but I see devel/libdev failing on recent main (tested
> > on aarch64):
> >
> > libtool: compile: cc -DHAVE_CONFIG_H -I. -O2 -pipe
> > -fstack-protector-strong -fno-strict-aliasing -MT event.lo -MD -MP -MF
> > .deps/event.Tpo -c event.c -fPIC -DPIC -o .libs/event.o
> > --- ev.lo ---
> > ev.c:510:11: fatal error: 'sys/statfs.h' file not found
> > 510 | # include <sys/statfs.h>
> > | ^~~~~~~~~~~~~~
>
> Are you able to test the patch below?
>
> diff --git a/devel/libev/files/patch-Makefile.in
> b/devel/libev/files/patch-Makefile.in
> index 5f6ab0fc3b55..509149e2548b 100644
> --- a/devel/libev/files/patch-Makefile.in
> +++ b/devel/libev/files/patch-Makefile.in
> @@ -1,6 +1,6 @@
> ---- Makefile.in.orig 2015-12-20 21:12:45 UTC
> +--- Makefile.in.orig 2020-03-18 12:27:30 UTC
> +++ Makefile.in
> -@@ -343,7 +343,7 @@ EXTRA_DIST = LICENSE Changes libev.m4 au
> +@@ -357,7 +357,7 @@ man_MANS = ev.3
> ev.3 ev.pod Symbols.ev Symbols.event
>
> man_MANS = ev.3
> diff --git a/devel/libev/files/patch-configure
> b/devel/libev/files/patch-configure
> index c92f6cf66003..6e5bf586cf34 100644
> --- a/devel/libev/files/patch-configure
> +++ b/devel/libev/files/patch-configure
> @@ -1,6 +1,6 @@
> ---- configure.orig 2015-12-20 21:12:45 UTC
> +--- configure.orig 2020-03-18 12:27:26 UTC
> +++ configure
> -@@ -3879,14 +3879,6 @@ else
> +@@ -3954,14 +3954,6 @@ fi
> fi
>
>
> diff --git a/devel/libev/files/patch-ev.c b/devel/libev/files/patch-ev.c
> index 28a00f3aaf8b..65b372e5415a 100644
> --- a/devel/libev/files/patch-ev.c
> +++ b/devel/libev/files/patch-ev.c
> @@ -1,6 +1,15 @@
> ---- ev.c.orig 2015-12-20 21:12:53 UTC
> +--- ev.c.orig 2020-03-18 12:27:32 UTC
> +++ ev.c
> -@@ -2736,7 +2736,7 @@ ev_recommended_backends (void) EV_THROW
> +@@ -507,7 +507,7 @@
> + #endif
> +
> + #if EV_USE_INOTIFY
> +-# include <sys/statfs.h>
> ++# include <sys/mount.h>
> + # include <sys/inotify.h>
> + /* some very old inotify.h headers don't have IN_DONT_FOLLOW */
> + # ifndef IN_DONT_FOLLOW
> +@@ -3149,7 +3149,7 @@ ev_recommended_backends (void) EV_NOEXCEPT
> {
> unsigned int flags = ev_supported_backends ();
>
>
--
Nuno Teixeira
FreeBSD UNIX: <eduardo@FreeBSD.org> Web: https://FreeBSD.org
[-- Attachment #2 --]
<div dir="ltr"><div><div><div><div>Hello Mark!<br><br></div>I confirm that it builds OK.<br></div>i3 wm depends on it, so I will have a run test in the next days.<br><br></div>Also I will update my main amd64 soon and test it in there too.<br><br></div>Thanks,</div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">Mark Johnston <<a href="mailto:markj@freebsd.org">markj@freebsd.org</a>> escreveu (quarta, 9/07/2025 à(s) 13:32):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Jul 09, 2025 at 01:13:02PM +0100, Nuno Teixeira wrote:<br>
> Hello,<br>
> <br>
> Not sure if related but I see devel/libdev failing on recent main (tested<br>
> on aarch64):<br>
> <br>
> libtool: compile: cc -DHAVE_CONFIG_H -I. -O2 -pipe<br>
> -fstack-protector-strong -fno-strict-aliasing -MT event.lo -MD -MP -MF<br>
> .deps/event.Tpo -c event.c -fPIC -DPIC -o .libs/event.o<br>
> --- ev.lo ---<br>
> ev.c:510:11: fatal error: 'sys/statfs.h' file not found<br>
> 510 | # include <sys/statfs.h><br>
> | ^~~~~~~~~~~~~~<br>
<br>
Are you able to test the patch below?<br>
<br>
diff --git a/devel/libev/files/patch-Makefile.in b/devel/libev/files/patch-Makefile.in<br>
index 5f6ab0fc3b55..509149e2548b 100644<br>
--- a/devel/libev/files/patch-Makefile.in<br>
+++ b/devel/libev/files/patch-Makefile.in<br>
@@ -1,6 +1,6 @@<br>
---- Makefile.in.orig 2015-12-20 21:12:45 UTC<br>
+--- Makefile.in.orig 2020-03-18 12:27:30 UTC<br>
+++ Makefile.in<br>
-@@ -343,7 +343,7 @@ EXTRA_DIST = LICENSE Changes libev.m4 au<br>
+@@ -357,7 +357,7 @@ man_MANS = ev.3<br>
ev.3 ev.pod Symbols.ev Symbols.event<br>
<br>
man_MANS = ev.3<br>
diff --git a/devel/libev/files/patch-configure b/devel/libev/files/patch-configure<br>
index c92f6cf66003..6e5bf586cf34 100644<br>
--- a/devel/libev/files/patch-configure<br>
+++ b/devel/libev/files/patch-configure<br>
@@ -1,6 +1,6 @@<br>
---- configure.orig 2015-12-20 21:12:45 UTC<br>
+--- configure.orig 2020-03-18 12:27:26 UTC<br>
+++ configure<br>
-@@ -3879,14 +3879,6 @@ else<br>
+@@ -3954,14 +3954,6 @@ fi<br>
fi<br>
<br>
<br>
diff --git a/devel/libev/files/patch-ev.c b/devel/libev/files/patch-ev.c<br>
index 28a00f3aaf8b..65b372e5415a 100644<br>
--- a/devel/libev/files/patch-ev.c<br>
+++ b/devel/libev/files/patch-ev.c<br>
@@ -1,6 +1,15 @@<br>
---- ev.c.orig 2015-12-20 21:12:53 UTC<br>
+--- ev.c.orig 2020-03-18 12:27:32 UTC<br>
+++ ev.c<br>
-@@ -2736,7 +2736,7 @@ ev_recommended_backends (void) EV_THROW<br>
+@@ -507,7 +507,7 @@<br>
+ #endif<br>
+ <br>
+ #if EV_USE_INOTIFY<br>
+-# include <sys/statfs.h><br>
++# include <sys/mount.h><br>
+ # include <sys/inotify.h><br>
+ /* some very old inotify.h headers don't have IN_DONT_FOLLOW */<br>
+ # ifndef IN_DONT_FOLLOW<br>
+@@ -3149,7 +3149,7 @@ ev_recommended_backends (void) EV_NOEXCEPT<br>
{<br>
unsigned int flags = ev_supported_backends ();<br>
<br>
</blockquote></div><div><br clear="all"></div><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div><font color="#888888">Nuno Teixeira</font></div><div><div><font color="#888888">
FreeBSD UNIX: <eduardo@FreeBSD.org> Web: <a href="https://FreeBSD.org" rel="noreferrer" target="_blank">https://FreeBSD.org</a><br></font></div></div></div></div>;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UJuJs3j3ZzKAR_1edktXXDC9f-wHzvmh3snW5eqUQsjhQ>