Date: Tue, 4 Jun 2019 14:48:35 -0400 From: Ed Maste <emaste@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r348611 - in head/sys: conf kern Message-ID: <CAPyFy2CkTcmVm-bH_s%2B6VVuTORQSueTxT2Ecg5LJyeMRJ5G-bA@mail.gmail.com> In-Reply-To: <13469B81-40A3-4F57-A8D3-FF8172385B5F@gmail.com> References: <201906041307.x54D7Acf058688@repo.freebsd.org> <13469B81-40A3-4F57-A8D3-FF8172385B5F@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Jun 2019 at 13:44, Enji Cooper <yaneurabeya@gmail.com> wrote: > > This is awesome! One minor critique is that I would have mentioned that t= he sysctl is `kern.build_id`. You mean including the sysctl name in the commit message? > How is this linked into uname(1) though? I don=E2=80=99t see any addition= al options added to the utility in this commit. It's a mistake in the commit message, and it's not yet hooked up - see https://reviews.freebsd.org/D20511. I split it out for a separate commit and forgot to update the submitted commit message.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CkTcmVm-bH_s%2B6VVuTORQSueTxT2Ecg5LJyeMRJ5G-bA>