Date: Sat, 21 Nov 2015 03:45:29 +0300 From: Andrey Chernov <ache@freebsd.org> To: Baptiste Daroussin <bapt@FreeBSD.org>, Jilles Tjoelker <jilles@stack.nl> Cc: "Sergey V. Dyatko" <sergey.dyatko@gmail.com>, freebsd-current@freebsd.org Subject: Re: /bin/ls formatting broken for non-C(?) locales Message-ID: <564FBEA9.7070100@freebsd.org> In-Reply-To: <20151121003541.GF21071@ivaldir.etoilebsd.net> References: <20151120110556.6e20a71f@laptop.minsk.domain> <20151120104253.GA21071@ivaldir.etoilebsd.net> <20151120110212.GB21071@ivaldir.etoilebsd.net> <20151120122352.GA5751@stack.nl> <20151121003541.GF21071@ivaldir.etoilebsd.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 21.11.2015 3:35, Baptiste Daroussin wrote: > Here is what I do propose (sorry for the ugly pad_to_col name, if one has better > please share :D > > https://reviews.freebsd.org/D4239 The whole function is ugly, not only its name. Please no hardcoded constants assuming some internal encoding knowledge, they are wrong for non-UTF-8 encodings in any case, use wide chars instead. BTW, the same 3 chars restriction is in tar, cpio, pax, lots of ftp clients, i.e. where 'ls' emulated. -- http://ache.vniz.net/ [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJWT76qAAoJEKUckv0MjfbKy0kH/1o5ZA4XwStZo5VY/U6BiEYo 1afEKSF+IdJTv9lG8tKjPN9YwlIt0cLLVT48UeIAIeYIYV4hwEgTLJ3JNb3RiZmz hxyG3wPrAtEN2AsCGCOGq6DqX4tWphpL42/N97u15cZyRgPUUifg7iKyFV8Dhwnv ZLIYq8X0SCGEm4pNHgQQXegRqs971WdwyQSOLbrmW2WsubAYGBc1bIckAopNJvQK CVOEBSpScidblTBNFTEYG+3iXV5QWR7dcJ/Pp4lTAhbPkaMIasahl7uZ26+bhuHL pYxAV4ijkR6Qdwd8fgv3DJmZ7d6Lu1Kcxy4W84Em5+XPju1BgQ84Pnj+tQkSMq4= =eCbV -----END PGP SIGNATURE-----help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?564FBEA9.7070100>