Date: Mon, 9 Mar 2009 20:25:36 +0100 From: Ed Schouten <ed@80386.nl> To: pluknet <pluknet@gmail.com> Cc: FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: panic: mutex Giant not owned at /usr/src/sys/kern/tty_ttydisc.c:1127 Message-ID: <20090309192536.GY19161@hoeg.nl> In-Reply-To: <a31046fc0903091221k656658cbv1a86c5a40fa6d1f4@mail.gmail.com> References: <a31046fc0903091221k656658cbv1a86c5a40fa6d1f4@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--GjdfNfZESPgSEIx8 Content-Type: multipart/mixed; boundary="SRdXq8ahTMo0Vx5K" Content-Disposition: inline --SRdXq8ahTMo0Vx5K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Can you try the attached patch? Let me know if it fixes the issue you're having. The reason why we're seeing such panics lately, is because the new TTY layer has one big improvement: it has assertions. This means that there are a lot of bugs in the old code where we call into the TTY layer without holding locks. Ugh. :-) --=20 Ed Schouten <ed@80386.nl> WWW: http://80386.nl/ --SRdXq8ahTMo0Vx5K Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="pluknet.diff" Index: syscons.c =================================================================== --- syscons.c (revision 189489) +++ syscons.c (working copy) @@ -3277,7 +3277,7 @@ sc_draw_cursor_image(scp); } tp = SC_DEV(sc, scp->index); - if (tty_opened(tp)) + if (!kdb_active && tty_opened(tp)) sctty_outwakeup(tp); #endif } --SRdXq8ahTMo0Vx5K-- --GjdfNfZESPgSEIx8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkm1bTAACgkQ52SDGA2eCwXWOQCfT3wG6jVPMaZFbcanbdJx3CTz cyAAnRMuH0a1QvnwM57N+Vu8Ad9vUn8w =smyp -----END PGP SIGNATURE----- --GjdfNfZESPgSEIx8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090309192536.GY19161>