Date: Thu, 7 Dec 2023 23:02:09 +0800 From: Zhenlei Huang <zlei@FreeBSD.org> To: Alan Somers <asomers@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>, li-Wen Hsu <lwhsu@freebsd.org> Subject: Re: git: 6b96125afdf2 - main - cap_net.3: remove a copypasta Message-ID: <5DC76457-C348-49C6-8EDE-763EB014D9DC@FreeBSD.org> In-Reply-To: <CAOtMX2gvox5qfm8dASpD-4Z3qAqM8v13BRUBs8fKWa98Gm_hpQ@mail.gmail.com> References: <202312061652.3B6GqOuf068349@gitrepo.freebsd.org> <44E8C9F3-84DD-4E51-B2A4-FB56E2A08F30@FreeBSD.org> <CAOtMX2gvox5qfm8dASpD-4Z3qAqM8v13BRUBs8fKWa98Gm_hpQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Dec 7, 2023, at 11:59 AM, Alan Somers <asomers@freebsd.org> wrote: > > On Wed, Dec 6, 2023 at 6:55 PM Zhenlei Huang <zlei@freebsd.org <mailto:zlei@freebsd.org>> wrote: >> >> >> >>> On Dec 7, 2023, at 12:52 AM, Alan Somers <asomers@freebsd.org> wrote: >>> >>> The branch main has been updated by asomers: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=6b96125afdf245ae61dd82b59891ad0d6aab0066 >>> >>> commit 6b96125afdf245ae61dd82b59891ad0d6aab0066 >>> Author: Alan Somers <asomers@FreeBSD.org> >>> AuthorDate: 2023-12-05 23:23:29 +0000 >>> Commit: Alan Somers <asomers@FreeBSD.org> >>> CommitDate: 2023-12-06 16:51:37 +0000 >>> >>> cap_net.3: remove a copypasta >>> >>> This line appears to have been copied from cap_sysctl.3. While I'm >>> here, reorder and reword the description of cap_net_limit a bit. >>> >>> [skip ci] >> >> I guess we can 'skip ci' implicitly for document or typo changes. > > Can we? The skipping logic is builtin to Jenkins, Github Workflows, > and Cirrus. I don't think it would be easy to program any of those to > detect which changes can be safely skipped. Sorry for the misleading word 'can', I think it is accurate to reword it to 'want to'. 1. To detect document changes, I think checking the names of changed files is sufficient. 2. As for the typo change, we can check the commit log. A false detecting (if the change is SKIP CI candidate) does not hurt much, as it will be queued up to next running of CI. So I think the simple logic above is practical. > -Alan [-- Attachment #2 --] <html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 7, 2023, at 11:59 AM, Alan Somers <<a href="mailto:asomers@freebsd.org" class="">asomers@freebsd.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta charset="UTF-8" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">On Wed, Dec 6, 2023 at 6:55 PM Zhenlei Huang <</span><a href="mailto:zlei@freebsd.org" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">zlei@freebsd.org</a><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">> wrote:</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><blockquote type="cite" style="font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><br class=""><br class=""><br class=""><blockquote type="cite" class="">On Dec 7, 2023, at 12:52 AM, Alan Somers <<a href="mailto:asomers@freebsd.org" class="">asomers@freebsd.org</a>> wrote:<br class=""><br class="">The branch main has been updated by asomers:<br class=""><br class="">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=6b96125afdf245ae61dd82b59891ad0d6aab0066" class="">https://cgit.FreeBSD.org/src/commit/?id=6b96125afdf245ae61dd82b59891ad0d6aab0066</a><br class=""><br class="">commit 6b96125afdf245ae61dd82b59891ad0d6aab0066<br class="">Author: Alan Somers <<a href="mailto:asomers@FreeBSD.org" class="">asomers@FreeBSD.org</a>><br class="">AuthorDate: 2023-12-05 23:23:29 +0000<br class="">Commit: Alan Somers <<a href="mailto:asomers@FreeBSD.org" class="">asomers@FreeBSD.org</a>><br class="">CommitDate: 2023-12-06 16:51:37 +0000<br class=""><br class=""> cap_net.3: remove a copypasta<br class=""><br class=""> This line appears to have been copied from cap_sysctl.3. While I'm<br class=""> here, reorder and reword the description of cap_net_limit a bit.<br class=""><br class=""> [skip ci]<br class=""></blockquote><br class="">I guess we can 'skip ci' implicitly for document or typo changes.<br class=""></blockquote><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">Can we? The skipping logic is builtin to Jenkins, Github Workflows,</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">and Cirrus. I don't think it would be easy to program any of those to</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">detect which changes can be safely skipped.</span><br style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none;" class=""></div></blockquote><div><br class=""></div><div>Sorry for the misleading word 'can', I think it is <span style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);" class="">accurate to</span> reword it to 'want to'.</div><div><br class=""></div><div>1. To detect document changes, I think checking the names of changed files is sufficient.</div><div>2. As for the typo change, we can check the commit log.</div><div><br class=""></div><div>A false detecting (if the change is SKIP CI candidate) does not hurt much, as it will be queued up</div><div>to next running of CI. So I think the simple logic <span style="caret-color: rgb(0, 0, 0); color: rgb(0, 0, 0);" class="">above is practical.</span></div><div><br class=""></div><blockquote type="cite" class=""><div class=""><span style="caret-color: rgb(0, 0, 0); font-family: Menlo-Regular; font-size: 13px; font-style: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;" class="">-Alan</span></div></blockquote></div><br class=""><div class=""> <div><br class=""></div> </div> <br class=""></body></html>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5DC76457-C348-49C6-8EDE-763EB014D9DC>