Date: Mon, 27 Sep 2010 08:53:44 -0700 From: Julian Elischer <julian@freebsd.org> To: sbruno@freebsd.org Cc: Sean Bruno <seanbru@yahoo-inc.com>, "current@freebsd.org" <current@freebsd.org> Subject: Re: MAXCPU preparations Message-ID: <4CA0BE08.50408@freebsd.org> In-Reply-To: <1285601161.7245.7.camel@home-yahoo> References: <1285601161.7245.7.camel@home-yahoo>
next in thread | previous in thread | raw e-mail | index | archive | help
On 9/27/10 8:26 AM, Sean Bruno wrote:
> Does this look like an appropriate modification to libmemstat?
>
> Sean
>
>
> ==== //depot/yahoo/ybsd_7/src/lib/libmemstat/memstat.h#4
> - /home/seanbru/ybsd_7/src/lib/libmemstat/memstat.h ====
> @@ -28,12 +28,13 @@
>
> #ifndef _MEMSTAT_H_
> #define _MEMSTAT_H_
> +#include<sys/param.h>
>
> /*
> * Number of CPU slots in library-internal data structures. This
> should be
> * at least the value of MAXCPU from param.h.
> */
> -#define MEMSTAT_MAXCPU 64
> +#define MEMSTAT_MAXCPU MAXCPU /* defined in
> sys/${ARCH}/include/param.h */
>
wouldn't it be better to do a sysctlbyname() and use the real value
for the system?
> /*
> * Amount of caller data to maintain for each caller data slot.
> Applications
>
>
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4CA0BE08.50408>