Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 2 Jan 2018 16:15:24 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r327492 - in stable/11/sys/cddl/dev/dtrace: amd64 i386
Message-ID:  <201801021615.w02GFOmK038250@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Tue Jan  2 16:15:24 2018
New Revision: 327492
URL: https://svnweb.freebsd.org/changeset/base/327492

Log:
  MFC r326935:
  Avoid CPU migration in dtrace_gethrtime() on x86.

Modified:
  stable/11/sys/cddl/dev/dtrace/amd64/dtrace_subr.c
  stable/11/sys/cddl/dev/dtrace/i386/dtrace_subr.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/cddl/dev/dtrace/amd64/dtrace_subr.c
==============================================================================
--- stable/11/sys/cddl/dev/dtrace/amd64/dtrace_subr.c	Tue Jan  2 16:14:36 2018	(r327491)
+++ stable/11/sys/cddl/dev/dtrace/amd64/dtrace_subr.c	Tue Jan  2 16:15:24 2018	(r327492)
@@ -353,11 +353,11 @@ SYSINIT(dtrace_gethrtime_init, SI_SUB_SMP, SI_ORDER_AN
  * Returns nanoseconds since boot.
  */
 uint64_t
-dtrace_gethrtime()
+dtrace_gethrtime(void)
 {
 	uint64_t tsc;
-	uint32_t lo;
-	uint32_t hi;
+	uint32_t lo, hi;
+	register_t rflags;
 
 	/*
 	 * We split TSC value into lower and higher 32-bit halves and separately
@@ -365,7 +365,10 @@ dtrace_gethrtime()
 	 * (see nsec_scale calculations) taking into account 32-bit shift of
 	 * the higher half and finally add.
 	 */
+	rflags = intr_disable();
 	tsc = rdtsc() - tsc_skew[curcpu];
+	intr_restore(rflags);
+
 	lo = tsc;
 	hi = tsc >> 32;
 	return (((lo * nsec_scale) >> SCALE_SHIFT) +

Modified: stable/11/sys/cddl/dev/dtrace/i386/dtrace_subr.c
==============================================================================
--- stable/11/sys/cddl/dev/dtrace/i386/dtrace_subr.c	Tue Jan  2 16:14:36 2018	(r327491)
+++ stable/11/sys/cddl/dev/dtrace/i386/dtrace_subr.c	Tue Jan  2 16:15:24 2018	(r327492)
@@ -355,11 +355,11 @@ SYSINIT(dtrace_gethrtime_init, SI_SUB_SMP, SI_ORDER_AN
  * Returns nanoseconds since boot.
  */
 uint64_t
-dtrace_gethrtime()
+dtrace_gethrtime(void)
 {
 	uint64_t tsc;
-	uint32_t lo;
-	uint32_t hi;
+	uint32_t lo, hi;
+	register_t eflags;
 
 	/*
 	 * We split TSC value into lower and higher 32-bit halves and separately
@@ -367,7 +367,10 @@ dtrace_gethrtime()
 	 * (see nsec_scale calculations) taking into account 32-bit shift of
 	 * the higher half and finally add.
 	 */
+	eflags = intr_disable();
 	tsc = rdtsc() - tsc_skew[curcpu];
+	intr_restore(eflags);
+
 	lo = tsc;
 	hi = tsc >> 32;
 	return (((lo * nsec_scale) >> SCALE_SHIFT) +



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201801021615.w02GFOmK038250>