Date: Fri, 24 Sep 2021 00:18:42 GMT From: Konstantin Belousov <kib@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 45c2c7c484de - main - aio_aqueue(): avoid ucred leak on failure path Message-ID: <202109240018.18O0Ig0s022550@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=45c2c7c484de7747014492b17ff89e323ee66496 commit 45c2c7c484de7747014492b17ff89e323ee66496 Author: Konstantin Belousov <kib@FreeBSD.org> AuthorDate: 2021-09-24 00:14:56 +0000 Commit: Konstantin Belousov <kib@FreeBSD.org> CommitDate: 2021-09-24 00:18:34 +0000 aio_aqueue(): avoid ucred leak on failure path PR: 258698 Submitted by: sigsys@gmail.com MFC after: 1 week --- sys/kern/vfs_aio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/kern/vfs_aio.c b/sys/kern/vfs_aio.c index 87c45bf2c078..d06b18140e71 100644 --- a/sys/kern/vfs_aio.c +++ b/sys/kern/vfs_aio.c @@ -1713,7 +1713,7 @@ no_kqueue: else error = fo_aio_queue(fp, job); if (error) - goto err3; + goto err4; AIO_LOCK(ki); job->jobflags &= ~KAIOCB_QUEUEING; @@ -1734,6 +1734,8 @@ no_kqueue: AIO_UNLOCK(ki); return (0); +err4: + crfree(job->cred); err3: if (fp) fdrop(fp, td);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202109240018.18O0Ig0s022550>