Date: Fri, 18 Aug 1995 19:29:38 PDT From: Bill Fenner <fenner@parc.xerox.com> To: FreeBSD-gnats-submit@freebsd.org Subject: kern/700: /sys/net/in.h comments scrogged Message-ID: <199508190229.TAA22436@baobab.parc.xerox.com> Resent-Message-ID: <199508190230.TAA08305@freefall.FreeBSD.org>
next in thread | raw e-mail | index | archive | help
>Number: 700
>Category: kern
>Synopsis: The comments in /sys/net/in.h are confusing
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Aug 18 19:30:02 PDT 1995
>Last-Modified:
>Originator: Bill Fenner
>Organization:
Xerox PARC
>Release: FreeBSD 2.0-BUILT-19950527 i386
>Environment:
-current source
>Description:
The comments that go with the structures in <net/in.h> don't appear to
actually go with the structures that they are near.
I have always associated the comment "would like to call this if" with
struct ifnet, but that comment is now near struct ifqueue. struct ifnet
is described as being information which may be of interest to management
entities, which sounds more like struct if_data. struct if_data has no
description at all.
>How-To-Repeat:
>Fix:
--- /usr/src/current/sys/net/if.h.orig Sat Aug 19 02:24:10 1995
+++ /usr/src/current/sys/net/if.h Sat Aug 19 02:24:43 1995
@@ -79,6 +79,10 @@
struct ether_header;
#endif
+/*
+ * Structure describing information about an interface
+ * which may be of interest to management entities.
+ */
struct if_data {
/* generic interface information */
u_char ifi_type; /* ethernet, tokenring, etc */
@@ -105,10 +109,7 @@
/*
* Structure defining a queue for a network interface.
- *
- * (Would like to call this struct ``if'', but C isn't PL/1.)
*/
-
struct ifqueue {
struct mbuf *ifq_head;
struct mbuf *ifq_tail;
@@ -118,8 +119,9 @@
};
/*
- * Structure describing information about an interface
- * which may be of interest to management entities.
+ * Structure defining a network interface.
+ *
+ * (Would like to call this struct ``if'', but C isn't PL/1.)
*/
struct ifnet {
char *if_name; /* name, e.g. ``en'' or ``lo'' */
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508190229.TAA22436>