Date: Thu, 15 Nov 2018 06:33:57 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 228596] [NEW PORT] finance/rippled: Reference server implementation of the Ripple protocol Message-ID: <bug-228596-7788-8qf1XUfpNy@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-228596-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-228596-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228596 --- Comment #1 from Tobias Kortkamp <tobik@freebsd.org> --- (In reply to waitman from comment #0) > should have at least 8GB RAM to build (according to rippled docs) So I guess I'm out in ever landing this. But here is a short review anyway: XMASTER_SITES=3D https://github.com/ripple/rippled/archive/ XDISTNAME=3D ${PORTVERSION} ... XWRKSRC=3D ${WRKDIR}/${PORTNAME}-${PORTVERSION} Please use USE_GITHUB and related variables here instead of GitHub's archive feature directly. XNO_ARCH=3D yes Huh? If the port builds binaries then this is probably wrong. X ${INSTALL} ${BUILD_WRKSRC}/rippled ${STAGEDIR}${PREFIX}/sbi= n/ Use INSTALL_PROGRAM. Also please fix the indentation here. X ${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.cfg ${STAGEDIR}${DOCS= DIR} X ${INSTALL_DATA} ${WRKSRC}/cfg/rippled-example.service ${STAGEDIR}${DOCSDIR} X ${INSTALL_DATA} ${WRKSRC}/cfg/rippled.init ${STAGEDIR}${DOCSDIR} X ${INSTALL_DATA} ${WRKSRC}/cfg/validators-example.txt ${STAGEDIR}${DOCSDIR} The *-example* files should probably be installed into EXAMPLESDIR (under an EXAMPLES option) instead. X @${CAT} ${WRKSRC}/MESSAGE What's the purpose of this? Nobody will see this message. It will be hidden in the build logs on the package builders. If this is a message for after the package has been installed, I suppose you could add PKGMESSAGE=3D ${WRKSRC}/MESSAGE to the port instead (then there is no point to also install it into DOCSDIR too). --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228596-7788-8qf1XUfpNy>