Date: Tue, 19 Dec 2017 10:00:11 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Greg 'groggy' Lehey <grog@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r326923 - stable/10/usr.bin/calendar/calendars Message-ID: <20171219090011.rikgg7xlckyuxr3l@ivaldir.net> In-Reply-To: <20171218230421.GE4376@eureka.lemis.com> References: <201712172212.vBHMCwYH026523@repo.freebsd.org> <20171218142306.zy46plfrctwhrcwg@ivaldir.net> <20171218230421.GE4376@eureka.lemis.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Tue, Dec 19, 2017 at 10:04:21AM +1100, Greg 'groggy' Lehey wrote: > On Monday, 18 December 2017 at 15:23:06 +0100, Baptiste Daroussin wrote: > > On Sun, Dec 17, 2017 at 10:12:58PM +0000, Greg Lehey wrote: > >> Author: grog > >> Date: Sun Dec 17 22:12:57 2017 > >> New Revision: 326923 > >> URL: https://svnweb.freebsd.org/changeset/base/326923 > >> > >> Log: > >> Correct character set. > > > > You are "correcting" a UTF-8 character into a ISO-8859 character directly in > > branch 10. > > > > This looks wrong in multiple way: > > 1. everything was converted into UTF-8 in 2011 on purpose > > For small values of "everything", maybe. I've checked three files: > calendar.history, fr_FR.ISO8859-1/calendar.fetes and > de_DE.ISO8859-1/calendar.geschichte. Only the first was in UTF-8. > > It sounds like a good idea to convert the files to UTF-8, but it has to be done > to all of them. And how about adding some information about the > preferred character set? We could kill two birds with one stone and > add this to the top of each file: Sorry I wasn't clear everything in that directory has been changed into UTF-8: r228991 For subdirectories it is less a problem as LANG is defined in each files to state the locale and then calendar(1) will itself switch to the defined locales. That said nowaday, most of the users of non ASCII countries are using UTF-8 only so if it was me I would rename all the ISO8859* calendars into UTF-8 ones and convert the locale to UTF-8. but hey :) BApt [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlo41RgACgkQY4mL3PG3 PlqohhAA5k0cUWccd4WJ1ZmgznlC3O7V6Wm/GfpaJHm04/IrQ7UejKtXibHLDtGS zQbd0xwqJUtuYf7OMl29PNQqY0lTvFfhlwHPcSb0lKtDd8L8YbCCW2oALltSw6yE fZLGSyL5OE7LDDLl4kIahsb91bIj7f05h2UdUbSHOMpcs/BdbBhiKepczr5Drf3+ VrpI0YyW0uea2bUzDGQlF7KOuLIrTiZM/1hLikz8Zs7qNF9Vf6o4J5TiiaEELKF0 aJp1uBR+wRAcyRT++6ENdiNWaOLhq06mh+T+1LXs2KtqSLAkmEkGrRlVnqdoYPrl ZDB19GFRWEdeox5T3qfNKq515RyHU0uQ3D/PLWJEGbAtAcqUPoKRkdg3KZ8j3quP 3/YLnW7X0dvnX//l9DB5TmLiwvqdDu+rzKa5cEUxC6VmthvoOxj/rMFFdEsGPiIL DrcP0aYFdgAXywrv8gNmkUpYTQSSqZ3lKbxwVhJz8idVv34I2v19ErRTLUrsbtBr 36nUrjEAxMCOkPqUWg8V0dNO4VUKGSjEh9zPcN7CHWRHtbDsghYkgSFsNydIZiIY QaHpOHl67qwxpwLpn88i8tQhQvSgEFsrJEPZHPAVhsDXnU7zfafGzxH+0Xfk+87S yTVxFHoHg/CYTXmdQB81BhLOHm/nHzstTv5Xtu3N0+8wDdL0v6M= =weCF -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171219090011.rikgg7xlckyuxr3l>