Date: Mon, 6 Mar 2017 21:01:59 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314831 - head/usr.bin/fortune Message-ID: <ECE94A0C-0CBE-425D-ADC5-113111E47BEC@gmail.com> In-Reply-To: <201703070500.v2750Qqd092455@pdx.rh.CN85.dnsmgr.net> References: <201703070500.v2750Qqd092455@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 6, 2017, at 21:00, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > > [ Charset UTF-8 unsupported, converting... ] >> Author: ngie >> Date: Tue Mar 7 04:33:17 2017 >> New Revision: 314831 >> URL: https://svnweb.freebsd.org/changeset/base/314831 >> >> Log: >> Don't rely on dependency in Makefile.inc1 for strfile; make datfiles depend on strfile >> >> In most cases strfile is built as part of build-tools, but in the event that someone >> cd'ed to the directory, tried to build from scratch, and had MK_GAMES=no previously, >> the build would fail in .../datfiles , trying to find strfile . >> >> Mark this directory tree "SUBDIR_PARALLEL" safe to help facilitate this, instead of >> shuffling around the SUBDIR entries (all of the other Makefiles will build standalone). >> >> MFC after: 1 week >> Sponsored by: Dell EMC Isilon >> >> Modified: >> head/usr.bin/fortune/Makefile >> >> Modified: head/usr.bin/fortune/Makefile >> ============================================================================== >> --- head/usr.bin/fortune/Makefile Tue Mar 7 04:13:22 2017 (r314830) >> +++ head/usr.bin/fortune/Makefile Tue Mar 7 04:33:17 2017 (r314831) >> @@ -1,5 +1,11 @@ >> # @(#)Makefile 8.1 (Berkeley) 5/31/93 >> +# >> +# $FreeBSD$ >> >> -SUBDIR= fortune strfile datfiles unstr >> +SUBDIR= fortune strfile datfiles unstr >> + >> +SUBDIR_DEPEND_datfiles= strfile > That should be a space, variable ends past column 9. "An ASCII space is allowed for variable names that extend beyond column 9. “ "is allowed” != “must”. Thanks, -Ngie [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvj7HAAoJEPWDqSZpMIYVrU0P/3HrKpkkcXhbICmE+D1LBUbH Xackvqo6y//qRoFNCm9pqWPCt2FbhxGyMzk6pbRtZ4JbfZgGcg8+eDpdrY+51zrw Bvlay+hWbjo/ErEZ14KUugJRZk5K0+msL98IchN6vqzmBnr3OFPJSuPiHGRWZwfw y5Z5Nd3SKwtwkJSwUa0wjAEnB97v8zCu5sGkv14HlGq7VfVKruMe+ydar/LwhNZI 1uK1ReVEuhwYr2msnvCeRt8E0R7ageQvp4IRGUkWzCOKmVzZYoaKgmMlYy8OvtFx PVJKpP/E3hoXo4fP7n/bEGbEvQk1uj/ZSqKZcamOOu9R6nAXDhNfYAnJCn6/JHEz XqMRPYztCWNRT6Za09UvHSaBtbFXy95gooKQwOIsqEnVdE7UjA/CGZiw6/5Kbz3j jgNgGMmEjwOZV6U3lAH+tQfxmuovVRxKbQC1EnbeBrrRjAxJgTOpASuBG6HYf76i pcLVTyolcV9SWvYuQWoIUdqvb4U9sjLCFGY6Kg0Z2EIJ0qe1FzKNAWG6yPR1tKPl BoxIMlP6SMKeDCWvLm30obARu465LX8CAuFMp9CwSYKHUr9DTKfijaIH21+OQre0 sUwaooYdjoWnlk97IXIEC0fd3dz9Ih8cZMUo1vXPchbuedEQV/o1sYtSXINvkvQU USyc7pnybZlVcT6dDRSW =kgjz -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ECE94A0C-0CBE-425D-ADC5-113111E47BEC>