Date: Thu, 27 Dec 2012 17:03:31 -1000 (TAHT) From: Gerald Pfeifer <gerald@pfeifer.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/174758: ports-mgmt/portlint: support USE_GCC=yes Message-ID: <alpine.LNX.2.00.1212271703050.4452@tuna.site> Resent-Message-ID: <201212280310.qBS3A0Vm094827@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 174758
>Category: ports
>Synopsis: ports-mgmt/portlint: support USE_GCC=yes
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 28 03:10:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Gerald Pfeifer
>Release:
>Organization:
>Environment:
>Description:
A few days ago, we added USE_GCC=yes as another (and now
preferred form of USE_GCC).
The patch below is a strawman of getting this supported by
portlint. I went ahead and made USE_GCC=any and USE_GCC=yes
a distinct check, so that we can become stricter in filtering
unsupported options of USE_GCC later on that someone might use.
>How-To-Repeat:
>Fix:
--- portlint.pl 2012-12-28 02:29:16.000000000 +0100
+++ portlint.new 2012-12-28 02:28:58.000000000 +0100
@@ -2035,7 +2035,9 @@
if ($whole =~ /^USE_GCC[?:]?=\s*(.*)$/m) {
my $lineno = &linenumber($`);
my $gcc_val = $1;
- if ($gcc_val =~ /3\.[234]\+/) {
+ if ($gcc_val eq 'any' || $gcc_val eq 'yes') {
+ # Just accept these two.
+ } elsif ($gcc_val =~ /3\.[234]\+/) {
&perror("WARN", $file, $lineno, "USE_GCC=3.2+, USE_GCC=3.3+, ".
"and USE_GCC=3.4+ are noops on all currently (and future) ".
"supported versions of FreeBSD. Do not use them.");
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LNX.2.00.1212271703050.4452>