Date: Fri, 30 Mar 2018 08:38:13 +0000 From: Pietro Cerutti <gahr@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: freebsd-hackers@FreeBSD.org Subject: Re: bmake: variable modifiers in SysV include Message-ID: <20180330083813.jfq3kwb5bzuhpeie@ptrcrt.ch> In-Reply-To: <4361.1522282416@kaos.jnpr.net> References: <20180328115825.ydfnbly6hpsvbo3h@ptrcrt.ch> <4361.1522282416@kaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--enbehtemswptyf5c Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mar 28 18 17:13, Simon J. Gerraty wrote: >Pietro Cerutti <gahr@FreeBSD.org> wrote: > >> our make (contrib/bmake) does not currently support variable modifiers >> in SysV-style "include" directives. See this simple example: > >> Apart from parentheses reshuffling, the patch just removes a check >> that inhibits SysV inclusion if the line being parsed contains a colon >> (:) character. >> >> This has been there since bmake has supported SysV includes [2]. >> >> Questions: >> >> 1. Any ideas why the check is there, and what problem it's preventing? >> 2. Anybody with src bit would like to approve me committing the fix? > >Can you pls fwd your issue to tech-toolchain@netbsd.org (cc me) >that way whoever it was who added the support for sysV style include >can comment. Hi Simon, I can't reply to Christos' email properly because I'm not subscribed to=20 that ML. Anyway, it looks like the original reason for the check on the=20 colon doesn't look too sustainable anymore :) Would you like to commit my fix to NetBSD? Thanks! --=20 Pietro Cerutti --enbehtemswptyf5c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJiBAABCgBMFiEE2m3hBqW4VLhd2G1JrdDTjqGSCJ4FAlq993EuFIAAAAAAFQAQ cGthLWFkZHJlc3NAZ251cGcub3JnZ2FockBGcmVlQlNELm9yZwAKCRCt0NOOoZII no2zEACLLP+84VjrsHyIk1sboPew+aeP5YxS/S0aDLGxYR91kRf3p/NMDg+VolC/ iFTHyd34t8jP1OXysMTRDwI3SMbTrQLGJXSNBam6sbS4+xNFNZ2UBHVuQfDYkBUS 29suIbMZowZvon+biBwJf7gFKKI9hUqVMFmEMc1N97zTFrb4Msr1GgRZETaI945P bbc2cKfHw6TbzvhAoyNH8S2iaIUUngFQrxQSMS729k45PhW7/QWP4xtxKQwSh80d wGtEGyVqrHHs4PqE8KkKYNOtWRhIHUh4rb2LQc4NGkkxSPqEZuiiiD2I8kePQRjO 7eCQSGQhs9fG2e9c4Rtms6JWUQ8XDTrzNu7P4cH28TQBXgW2pAR1OV5Dbppf4PVz S/oUMpefW1RasQTykcL9BlFI97P0Z57in/ufgyWhMXxBmtQUCrAUfo06KDoNtu/i 9wChYWkdw0jtyoD7yAAhLOautA4yGKb29lJM+JWw+rWLew3WQ+KFpN/ZMxd524wI heBIrCmGjIb9eQOEt7WEDfdxVCUmj4vrakclCG/e7W6VpXtHUg2elWAwboYvjWBu H9ilk11AO/G1vsl1WXcxpMhSs4j4WzjVj044BOJ3hakdcGvi3RgSzHrbaE4hz42F 0eVRIgeP0PBWYGzKxMLEXz8GZwu4NsdDoqZjoDNbixuWK26gfA== =IX13 -----END PGP SIGNATURE----- --enbehtemswptyf5c--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180330083813.jfq3kwb5bzuhpeie>