Date: Sat, 15 Nov 2025 21:33:16 +0000 (UTC) From: "Bjoern A. Zeeb" <bz@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a615ded5bf2d - main - sys/conf/files: Add iwx driver Message-ID: <462npnsp-7o16-q664-65pn-q6o76rrp375q@SerrOFQ.bet> In-Reply-To: <86346fuhny.fsf@ltc.des.dev> References: <202511150319.5AF3JZxn087193@gitrepo.freebsd.org> <975p35no-15n8-q8o8-r154-r3517o4o6oqs@mnoonqbm.arg> <86346fuhny.fsf@ltc.des.dev>
index | next in thread | previous in thread | raw e-mail
On Sat, 15 Nov 2025, Dag-Erling Smørgrav wrote:
> "Bjoern A. Zeeb" <bz@FreeBSD.org> writes:
>> Dag-Erling Smørgrav <des@FreeBSD.org> writes:
>>> +dev/iwx/if_iwx.c optional iwx \
>>> + compile-with "${NORMAL_C} -DIWX_DEBUG=1"
>>> +dev/iwx/if_iwx_debug.c optional iwx \
>>> + compile-with "${NORMAL_C} -DIWX_DEBUG=1"
>> Why would we add the debug flag in a default kernel compile?
>
> Because the driver doesn't build without it. Feel free to fix that, but
> don't forget to turn debugging off in the module build as well.
Took me 3 minutes to make it build without IWX_DEBUG:
https://reviews.freebsd.org/D53776
No I did not add the kernel option yet... whoever needs it can but could
likely equally just add a #define IWX_DEBUG to the source file.
/bz
--
Bjoern A. Zeeb r15:7
home |
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?462npnsp-7o16-q664-65pn-q6o76rrp375q>