Date: Sun, 2 Jan 2022 15:01:29 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: Alan Somers <asomers@freebsd.org> Cc: Ed Maste <emaste@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: daf481f3d508 - main - rescue: include ping iff at least one of INET & INET6 is enabled Message-ID: <YdIuySlz9IQAagcG@FreeBSD.org> In-Reply-To: <CAOtMX2geeDJdGWz7a-Jt%2BUUTxj7F5TyP77RTh4dDfYP1mJXX%2BA@mail.gmail.com> References: <202112311818.1BVIIr2P048142@gitrepo.freebsd.org> <YdHeJSMMJP3t750f@FreeBSD.org> <CAOtMX2geeDJdGWz7a-Jt%2BUUTxj7F5TyP77RTh4dDfYP1mJXX%2BA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jan 02, 2022 at 10:21:28AM -0700, Alan Somers wrote: A> On Sun, Jan 2, 2022 at 10:17 AM Gleb Smirnoff <glebius@freebsd.org> wrote: A> > A> > On Fri, Dec 31, 2021 at 06:18:53PM +0000, Ed Maste wrote: A> > E> The branch main has been updated by emaste: A> > E> A> > E> URL: https://cgit.FreeBSD.org/src/commit/?id=daf481f3d508e7497b456e8df7db17c90b623ee0 A> > E> A> > E> commit daf481f3d508e7497b456e8df7db17c90b623ee0 A> > E> Author: Ed Maste <emaste@FreeBSD.org> A> > E> AuthorDate: 2021-12-31 01:11:31 +0000 A> > E> Commit: Ed Maste <emaste@FreeBSD.org> A> > E> CommitDate: 2021-12-31 18:16:30 +0000 A> > E> A> > E> rescue: include ping iff at least one of INET & INET6 is enabled A> > E> A> > E> Ping does not build (and serves no purpose) if neither is enabled A> > E> (i.e., building WITHOUT_INET and WITHOUT_INET6). A> > E> A> > E> This is equvalent to a4ef9e58bc0c but for rescue/. A> > E> A> > E> PR: 260082 A> > E> Fixes: a4ef9e58bc0c ("sbin: build ping if at least one of...") A> > E> Sponsored by: The FreeBSD Foundation A> > A> > Shouldn't be ping built only with INET and ping6 with INET6? A> > Is there any use of ping on machine that doesn't have IPv4? A> > A> > -- A> > Gleb Smirnoff A> A> In 14.0-CURRENT, ping and ping6 are the same binary. However, parts A> of that binary are conditionally compiled by INET and INET6. Sorry, I missed that. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YdIuySlz9IQAagcG>