Date: Thu, 10 Aug 2017 20:18:17 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 221397] ports-mgmt/portlint: Shouldn't suggest to use $(VARIABLE) in replacement clauses Message-ID: <bug-221397-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221397 Bug ID: 221397 Summary: ports-mgmt/portlint: Shouldn't suggest to use $(VARIABLE) in replacement clauses Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: marcus@FreeBSD.org Reporter: yuri@rawbw.com Assignee: marcus@FreeBSD.org Flags: maintainer-feedback?(marcus@FreeBSD.org) Created attachment 185241 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D185241&action= =3Dedit Makefile (testcase) This statement > @${REINPLACE_CMD} -e ' \ > s|ExtraCompiler.commands =3D $$$${QMAKE_CXX} -fPIC|ExtraC= ompiler.commands =3D $$$${QMAKE_CXX} $$(CXXFLAGS) -fPIC|g' \ > ${WRKSRC}/polyphone.pro makes 'portlint -A' print: > WARN: /usr/ports/audio/polyphone/pkg-plist: There are only 4 items in the= plist. Consider using PLIST_FILES instead of pkg-plist when installing le= ss than 6 items. > WARN: Makefile: [44]: use ${VARIABLE}, instead of $(VARIABLE). It shouldn't complain about a double-dollared varable $$(CXXFLAGS), because= it specifies a replacement string, not a Makefile string. Additionally, the line it complains is ${WRKSRC}/polyphone.pro, not the act= ual line. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221397-13>