Date: Wed, 22 Oct 2014 22:47:48 +0100 From: Tony Moseby <tsmoseby@yahoo.no> To: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> Subject: patches Message-ID: <1414014468.49733.YahooMailNeo@web172806.mail.ir2.yahoo.com>
next in thread | raw e-mail | index | archive | help
Hello,=0A=0AA simple question,if I want to know if there is a patch for my= =0Aproblem where should i Look?is there a data base or similar with=0Aall p= atches for every source code file ? or how does one goes about.=0AMany than= ks=0A From owner-freebsd-net@FreeBSD.ORG Wed Oct 22 21:55:48 2014 Return-Path: <owner-freebsd-net@FreeBSD.ORG> Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 801B9B16; Wed, 22 Oct 2014 21:55:48 +0000 (UTC) Received: from mail-pd0-x233.google.com (mail-pd0-x233.google.com [IPv6:2607:f8b0:400e:c02::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 52A2DA22; Wed, 22 Oct 2014 21:55:48 +0000 (UTC) Received: by mail-pd0-f179.google.com with SMTP id r10so4347717pdi.10 for <multiple recipients>; Wed, 22 Oct 2014 14:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=lYaral+f2i0Bd9W/bVfl6L1YrIHT6/TqG3BYdjDYgqw=; b=y6/aeMa3vDXaguDb5EjzdA5I1wuPqLtmrp7H0pWN8/3MaVMkPW3QvI7n6PLxb3Wriz ma1Mr+q70NEYWWnurzu12itwjP/epHrs+n/WvVjJjCiwTjYw/rJSCnpYQ34oWg6tBxzb WF2/pi8OWdH7L6nwpormbRfpRqxl8rURTZeNhQtM65zGOw5pGHmio2FB3OiPbrto/Xpg 1cJJA/YqzvKzo0cF3uhxHLDgKQotCCuEj7SR9aS+V6peog4H503ztv3UwWeqKEpeMuAI /YtCsRzMcCx1k0Rg2o4LlQ1+axJGIuzIYNUGTVYQbdJ+/ikH7qjOzMwBDuZ31SPIbOOO OR4Q== X-Received: by 10.66.251.194 with SMTP id zm2mr700747pac.33.1414014947868; Wed, 22 Oct 2014 14:55:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.70.24.101 with HTTP; Wed, 22 Oct 2014 14:55:07 -0700 (PDT) In-Reply-To: <54478A59.10804@FreeBSD.org> References: <54478A59.10804@FreeBSD.org> From: Eric Joyner <ricera10@gmail.com> Date: Wed, 22 Oct 2014 14:55:07 -0700 Message-ID: <CA+b0zg98iKqfX32hJHLQZX5jtqE0X8_wma_uYEAkewCyrXdM-Q@mail.gmail.com> Subject: Re: ixgbe ifmedia handling To: "Alexander V. Chernikov" <melifaro@freebsd.org> Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org> X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>; List-Post: <mailto:freebsd-net@freebsd.org> List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>, <mailto:freebsd-net-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 22 Oct 2014 21:55:48 -0000 Hi, On Wed, Oct 22, 2014 at 3:43 AM, Alexander V. Chernikov < melifaro@freebsd.org> wrote: > There is a problem with correct media reporting in ixgbe: > > ixgbe_setup_optics() is called only at ixgbe_attach(). > This means that: > 1) if SFP slot was empty at the attach() time, "media" part will be set to > adapter->optics = IFM_ETHER | IFM_AUTO; > e.g. after attaching SFP status will look like > media: Ethernet autoselect (autoselect <full-duplex>) > status: active > 2) If SFP slot was not empty, ifmedia will not be updated. > > The former case may trigger problems in other places inside kernel relying > for ifmedia to be set correctly. > For example, ifmedia_baudrate() will return 0 for given active interface > (and this breaks best LACP aggregator selection > making lagg interface attach impossible until module unload or reboot. > > Attached patch seems to work for 82599 NIC, but I'm pretty sure that it > needs more checks. > (And I wonder if we have the same problems with if_ixl). > Your attached patch seems to work okay, but it doesn't deal with changing the baudrate. I don't think we should print out a message every time an SFP module is removed though. Aside from that, what kind of checks should there be? > > While investigating this case/performing tests I've noticed the following: > > * code inside ixgbe_local_timer() probing SFP seems to be dead > /* Check for pluggable optics */ > if (adapter->sfp_probe) > was always false (due to failure to detect/set IXGBE_ERR_SFP_NOT_PRESENT > status?) I will look at removing that. > > * ixgbe_handle_mod() was triggered in 1/4 of cases: > e.g. if you detach SFP witin 2-3 seconds after attach it will not trigger. > Even if detaching SFP which was inserted half an hour ago (and link was > UP) this interrupt does not always trigger. > You mean ixgbe_handle_msf(), right? I've just tried it, and noticed the same thing you do. I think this could be extended -- it'd be good to change if_baudrate when the media type changes if that value is important. For adding to the list of media types, it sounds like it could be an unnecessary hassle. Is it important to be able to force speeds using ifconfig media types vs a sysctl? - Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1414014468.49733.YahooMailNeo>