Date: Mon, 31 May 2021 20:21:29 +0100 From: Jessica Clarke <jrtc27@jrtc27.com> To: Warner Losh <imp@bsdimp.com> Cc: Ed Maste <emaste@freebsd.org>, Alan Somers <asomers@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 5a20c351ea45 - main - [skip ci] add a CODEOWNERS file Message-ID: <E778BD5D-1A73-42B0-93F1-871D7E0AC5EC@jrtc27.com> In-Reply-To: <CANCZdfoBa%2Bv8dBk6U3o2wW%2Bc-8w_fcHi85=9ZdiQfu1%2B=HAFdg@mail.gmail.com> References: <202105302249.14UMnbcl094541@gitrepo.freebsd.org> <CAPyFy2AHmrjdWyKnUMwEf5TnYub4j6um_rYHW6vwmvxR8g6LHw@mail.gmail.com> <CAOtMX2g7mHxQ3%2B0LWhwXLcDgrH0kedb2VrnPV9wmJMnA%2B6ZJDA@mail.gmail.com> <CAPyFy2DFUeEFGPD1tYcK48EcQkDd7DOBgmTwqXE5oj60qOsPKQ@mail.gmail.com> <CANCZdfoBa%2Bv8dBk6U3o2wW%2Bc-8w_fcHi85=9ZdiQfu1%2B=HAFdg@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On 31 May 2021, at 20:16, Warner Losh <imp@bsdimp.com> wrote: > > > > On Mon, May 31, 2021, 1:11 PM Ed Maste <emaste@freebsd.org> wrote: > On Mon, 31 May 2021 at 11:51, Alan Somers <asomers@freebsd.org> wrote: > > > >> > >> I think this file isn't the right place for (another copy of) this > >> text; perhaps the CODEOWNERS file should just reference the top-level > >> MAINTAINERS? > > > > Except that CODEOWNERS is in a format that tools know how to parse. If anything, MAINTAINERS should be a symlink to CODEOWNERS. > > At least the file's location and user IDs suggest that it is specific > to GitHub; in any case I don't really care which one points to which. > I hope we can agree though that we don't really want two different > files representing code ownership in different ways that both > independently refer to a third mechanism for recording code ownership > that's external to the source tree? > > It also works on gitlab, FWIW. The format is standard. Bummer we can't generate it based on where it is published… We could conceivably have a CODEOWNERS.master from which the others can be generated via `make codeowners` whenever someone edits it. Whether that’s worth the hassle of implementing though for a file that shouldn’t regularly be changing is unclear. Jesshelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E778BD5D-1A73-42B0-93F1-871D7E0AC5EC>