Date: Tue, 6 Nov 2001 18:33:30 +0200 From: Peter Pentchev <roam@ringlet.net> To: Murray Stokely <murray.stokely@windriver.com> Cc: Murray Stokely <murray@FreeBSD.org>, doc@FreeBSD.org Subject: Re: TIDYFLAGS fixes all around the tree Message-ID: <20011106183330.J10023@straylight.oblivion.bg> In-Reply-To: <20011106083554.W1818@windriver.com>; from murray.stokely@windriver.com on Tue, Nov 06, 2001 at 08:35:54AM -0800 References: <20011105175820.D77919@straylight.oblivion.bg> <20011105124156.D10872@windriver.com> <20011106125323.E10023@straylight.oblivion.bg> <20011106083554.W1818@windriver.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 06, 2001 at 08:35:54AM -0800, Murray Stokely wrote:
> On Tue, Nov 06, 2001 at 12:53:25PM +0200, Peter Pentchev wrote:
> > Okay, so I was working from an 8-9 hours' old tree. Still, maybe
> > I'm being dumb, but I do not really see the point of the fix you
> > committed. It definitely does not fix the problem I reported,
> > as seen by:
> >
> > [roam@straylight:v4 ~/fbsd/r/doc/ru_RU.KOI8-R/articles/explaining-bsd]$ make -V TIDYFLAGS
> > -latin1
> >
> > As you can see, still no -m :(
>
> [amd] /usr/doc/ru_RU.KOI8-R/articles/explaining-bsd> make TIDYFLAGS=-latin1
> [ jade output snipped ]
> /usr/local/bin/tidy -i -m -f /dev/null -latin1 article.html
> Can't open "/export/home/murray/.tidyrc"
> *** Error code 1 (ignored)
>
> Seems to be working now.
>
> TIDYFLAGS is the user settable variable for additional flags to tidy,
> while 'TIDYOPTS' is the internal makefile variable for the complete
> set of flags to tidy.
>
> TIDYOPTS= <defaults> ${TIDYFLAGS}
Eep. Okay. Point taken. Never Never Never reply to e-mail in
the early morning hours (like 11am)..
Yes, I tested an actual build now, and it seems to work.. thanks! :)
> > As I already said, I do not see the point of 'VAR?= blah ${VAR}'.
>
> TIDY?= ${PREFIX}/bin/tidy
> TIDYOPTS?= -i -m -f /dev/null ${TIDYFLAGS}
>
> This is not a case of VAR?= blah ${VAR}. It is a case of B?= bla ${A}
Yep.. I need to look a bit more careful next time :)
> > This statement only ever changes the value of VAR if VAR *is not set*.
> > In that case, ${VAR} is empty, and VAR is set to 'blah'. If VAR is
> > already set, then this statement will have absolutely no effect :)
>
> I agree. If you find a case like that in our makefiles, please fix
> it. ;)
Sure will :)
G'luck,
Peter
--
"yields falsehood, when appended to its quotation." yields falsehood, when appended to its quotation.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011106183330.J10023>