Date: Fri, 26 Apr 2002 14:43:57 -0700 (PDT) From: Hiten Pandya <hitmaster2k@yahoo.com> To: John Baldwin <jhb@FreeBSD.org>, Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c Message-ID: <20020426214357.91921.qmail@web21104.mail.yahoo.com> In-Reply-To: <XFMail.20020426165751.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--- John Baldwin <jhb@FreeBSD.org> wrote: > Mutex profiling counts as kernel work I think. The problem was that > the original commit was not fully tested. However, bugfixes should > still be tested before they go in. Even having the submitter of the > bug report test the patch before it goes in is sufficient and doesn't > require you to reboot your own machine. Well, as far as my memory goes, I did test the patch as far "booting" the machine was concerned. I did not get the panic aftet the Copyright and Build messages so for me, the problem was solved right there, I dont know anything further. > You can't be calling malloc while holding a spin lock. I would lock the > mutex, read the contents of an item from the array into stack variables, > unlock the mutex, then do the sbuf operation. I also suggest you _test_ > this before committing the fix. The above patch was tested as far as the panic message was concerned. -- Hiten __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020426214357.91921.qmail>