Date: Sun, 7 Apr 2019 13:33:59 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Mariusz Zaborski <oshogbo@freebsd.org> Cc: Cy Schubert <Cy.Schubert@cschubert.com>, rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345982 - in head: include lib/libc/sys sys/cddl/compat/opensolaris/sys sys/compat/cloudabi sys/compat/freebsd32 sys/compat/linux sys/kern sys/sys sys/ufs/ffs Message-ID: <20190407173359.vc2fwmnsbky7dlkj@mutt-hbsd> In-Reply-To: <20190407161158.GA40247@x-wing> References: <freebsd@gndrsh.dnsmgr.net> <201904071510.x37FA7tm050626@gndrsh.dnsmgr.net> <201904071535.x37FZ7bk073860@slippy.cwsent.com> <20190407161158.GA40247@x-wing>
next in thread | previous in thread | raw e-mail | index | archive | help
--h5gs4klk52ndinq6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable No worries. Thanks for the correction! --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 On Sun, Apr 07, 2019 at 06:11:58PM +0200, Mariusz Zaborski wrote: > In the https://wiki.freebsd.org/AddingSyscalls we mentions that we need t= o bump > __FreeBSD_version. I confirmed that with Warner. So this was my mistake. >=20 > Thanks Shawn. > --=20 > Mariusz Zaborski > oshogbo//vx | http://oshogbo.vexillium.org > FreeBSD committer | https://freebsd.org > Software developer | http://wheelsystems.com > If it's not broken, let's fix it till it is!!1 >=20 > On Sun, Apr 07, 2019 at 08:35:07AM -0700, Cy Schubert wrote: > > In message <201904071510.x37FA7tm050626@gndrsh.dnsmgr.net>, "Rodney W.= =20 > > Grimes" > > writes: > > > > On April 7, 2019 7:11:52 AM PDT, Shawn Webb <shawn.webb@hardenedbsd= =2Eorg> wr > > > ote: > > > > >On Sat, Apr 06, 2019 at 09:34:26AM +0000, Mariusz Zaborski wrote: > > > > >> Author: oshogbo > > > > >> Date: Sat Apr 6 09:34:26 2019 > > > > >> New Revision: 345982 > > > > >> URL: https://svnweb.freebsd.org/changeset/base/345982 > > > > >>=20 > > > > >> Log: > > > > >> Introduce funlinkat syscall that always us to check if we are > > > > >removing > > > > >> the file associated with the given file descriptor. > > > > >> =20 > > > > >> Reviewed by: kib, asomers > > > > >> Reviewed by: cem, jilles, brooks (they reviewed previous versi= on) > > > > >> Discussed with: pjd, and many others > > > > >> Differential Revision: https://reviews.freebsd.org/D14567 > > > > > > > > > >Hey Mariusz, > > > > > > > > > >Is __FreeBSD_version supposed to be bumped after adding new syscal= ls? > > > > >I can't remember off-hand. > > > > > > > > > >Thanks, > > > >=20 > > > > I don't think so. Why force the rebuild of all ports through poudri= ere over > > > something that would never affect any of them? > > > > > > So that you can if version >=3D foo to know it is safe to use the new= syscal? > > > Or if version < foo you must use the old way. > >=20 > > Granted. However we do need something to avoid gratuitous rebuilds of= =20 > > ports. > >=20 > > Personally, my poudriere script adjusts the pkg version=20 > > ($JAILPATH/data/packages/${JAIL}-${PORTS}/.building/.jailversion) with= =20 > > that of the jail version (reported by poudriere jail -i -j $JAIL),=20 > > rebuilding all ports when I (the human) determines when the machine=20 > > should rebuild all ports with -c. > >=20 > > In that regard FreeBSD version bumps occasionally seem a little=20 > > gratuitous. Using the same indicator to tell whether software should be= =20 > > able to use a new feature and when ports build infrastructure should=20 > > summarily delete all packages forcing a rebuild of absolutely=20 > > everything is probably not the best. > >=20 > > Just throwing out an idea, what if poudriere considers the first N=20 > > bytes of __FreeBSD_version significant? Having said that, looking at=20 > > __FreeBSD_version, I don't think we have enough digits to do what I was= =20 > > planning on suggesting. But, you get the idea of what I'm driving at.= =20 > > Maybe a new macro such as __FreeBSD_ports that is incremented every=20 > > time a change that affects ports? > >=20 > > Anyhow, I'm not too terribly concerned as what I have (selfishly=20 > > speaking) works. But we may as a group might want to consider this at= =20 > > some point to build some efficiency into the ports part of the equation. > >=20 > >=20 > > --=20 > > Cheers, > > Cy Schubert <Cy.Schubert@cschubert.com> > > FreeBSD UNIX: <cy@FreeBSD.org> Web: http://www.FreeBSD.org > >=20 > > The need of the many outweighs the greed of the few. > > =20 > >=20 --h5gs4klk52ndinq6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAlyqNIAACgkQ/y5nonf4 4fr28xAAh1pFG/uwPHj1IgEn40Dm66GilPg84s02U2zbRzmV3rfCXK7jeN2yysVm eKZCzJtrdyXZeG7syqibhGvNRaIYcxXcStQFWl+G2qT/iPpLw9PdJI987TzRyKqY uXX8Stxsc7g1Nz/48HD7aXXv6wa42SXO2XNSlOR4o6S0lh2hKefYFteD2ftSoMK6 JT7+yCLzQJQU0BIvP4kT/FPMSfg/eCjR1FqGOXVkv4VygaVGoP3QUs4VAszwbh9E inBl8oQr2jZF9w09OlHf7w5vSp0vYhs34McIi4BonyaEhUz7jjNZ6BdbjOrwo85g o28/agMPeDvP25mM3Ifyn2F9U8etM2Y4WrPyIc8fYPSuCxgfTpnfiF2dN74t6Epc mzbwickapoadulnEeCIW/Z9R/FS5TTiGgkKl7u7YKL8QDZu96gjJn8PBsSDy4PaH 9j+8MEaz0J4eiAU+SEySrTU2GWW6RuzbZ6hymVXLlNzZfpG3Z9oRNgOD41dG+Y49 /3pF9ZhL2XLMTMxDZLPGSyv9AbOijTdmzZuTTj9U2/Ei2DT4Yyy0+zp1iOlpy9dg LHq5Nvztuk9yA7Ig25s6952CseuvjnscJ/5yHng2QPdGpEXcme9lY1yjZF/70tn5 MZGYo38hr6kwnLHTJ38ucw2FT+uV2cPuzKbwqxW31eOuI1T7gyM= =K2n/ -----END PGP SIGNATURE----- --h5gs4klk52ndinq6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190407173359.vc2fwmnsbky7dlkj>