Date: Mon, 6 Mar 2017 21:07:18 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: rgrimes@freebsd.org Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314831 - head/usr.bin/fortune Message-ID: <A259246A-A280-496F-81FC-738F308563B6@gmail.com> In-Reply-To: <ECE94A0C-0CBE-425D-ADC5-113111E47BEC@gmail.com> References: <201703070500.v2750Qqd092455@pdx.rh.CN85.dnsmgr.net> <ECE94A0C-0CBE-425D-ADC5-113111E47BEC@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] > On Mar 6, 2017, at 21:01, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > >> On Mar 6, 2017, at 21:00, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >> >> [ Charset UTF-8 unsupported, converting... ] >>> Author: ngie >>> Date: Tue Mar 7 04:33:17 2017 >>> New Revision: 314831 >>> URL: https://svnweb.freebsd.org/changeset/base/314831 >>> >>> Log: >>> Don't rely on dependency in Makefile.inc1 for strfile; make datfiles depend on strfile >>> >>> In most cases strfile is built as part of build-tools, but in the event that someone >>> cd'ed to the directory, tried to build from scratch, and had MK_GAMES=no previously, >>> the build would fail in .../datfiles , trying to find strfile . >>> >>> Mark this directory tree "SUBDIR_PARALLEL" safe to help facilitate this, instead of >>> shuffling around the SUBDIR entries (all of the other Makefiles will build standalone). >>> >>> MFC after: 1 week >>> Sponsored by: Dell EMC Isilon >>> >>> Modified: >>> head/usr.bin/fortune/Makefile >>> >>> Modified: head/usr.bin/fortune/Makefile >>> ============================================================================== >>> --- head/usr.bin/fortune/Makefile Tue Mar 7 04:13:22 2017 (r314830) >>> +++ head/usr.bin/fortune/Makefile Tue Mar 7 04:33:17 2017 (r314831) >>> @@ -1,5 +1,11 @@ >>> # @(#)Makefile 8.1 (Berkeley) 5/31/93 >>> +# >>> +# $FreeBSD$ >>> >>> -SUBDIR= fortune strfile datfiles unstr >>> +SUBDIR= fortune strfile datfiles unstr >>> + >>> +SUBDIR_DEPEND_datfiles= strfile >> That should be a space, variable ends past column 9. > > "An ASCII space is allowed for variable names that extend beyond column 9. “ > > "is allowed” != “must”. And being extremely aesthetically nitpicky, as the queer person I am with my attention to colors and design (:P..), I would be kind of annoyed with right hand sides being unaligned, e.g., SOMETHING_REALLY_LONG= foo # 1 hard tab SOMETHING_SHORTER= bar # 2 hard tabs vs SOMETHING_REALLY_LONG= foo # 1 space SOMETHING_SHORTER= bar # 2 spaces [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYvkAGAAoJEPWDqSZpMIYVy3wP/2+hrG3RZvJOSH68V9whb5DA 8LK8eOs1Z+YMmbtX0JCc6Zr5MUcAMg/Ta3LlLQXpnOtF7n3otswLS37LJoZKNU/O 1CUK90mMeSlAEysjvprg7NW9rxyxceJEcm/ClyLDMImzbSMSHnlCkO7yYxhr/ZGw kZ1dC1mI2I3bWtzPrjDou4eLQGD5If68oJLlrJi+q0grWdHo9io30UVz/snrC9Y3 LIyqyiYdFLS8kYxwMs7GQG1WNH3nFKokuuovLxQwWL4n2Rt084DBdAWMP0sQ3Bw5 HkDlMY15mdQ+WjomD8dZG3uW4csweTZCWxmzQd5mRb+/cKdukharlv8BF0yellOJ i1M5MLIsG0k8VrhuqrWkIG35AbS6a5FsLffIDn+LzoGuGNdvYHiyXJWsFk16H+i2 j/jt31sFlMW/43P4OROxjjj8tvIb29BDeEVXhFX4pSYD9wXKB3dj5t87GViXkji9 /ttKtBCZ73WBQ2wk4n9mbwsDCdS3n/0oKo0hyP/eWSa2+t0zfOTRdzGpF72/4SD7 Fukw0avklGuf3w5q6SlsInnBusLcX/bTCDpb0y6LoyzP+7fqhzzj8m2qncoOMEWd e7l7yeCQhqIUAP+aWoj7oX1F2Ibzbhdwutn5FcQZh5WJhnUA+z4tkjPnGDScswnR i3Ipxcmf4iHMkSwXdxZN =eYIY -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A259246A-A280-496F-81FC-738F308563B6>