Date: Fri, 13 Nov 2015 13:02:59 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Randall Stewart <rrs@netflix.com> Cc: "Alexander V. Chernikov" <melifaro@freebsd.org>, Randall Ray Stewart <rrs@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, Adrian Chadd <adrian@freebsd.org>, imp@freebsd.org Subject: Re: svn commit: r290664 - in head: share/man/man9 sys/kern sys/sys Message-ID: <56465003.8070709@FreeBSD.org> In-Reply-To: <CCAE1243-3DC1-4077-BC55-AA6EA7750181@netflix.com> References: <201511101449.tAAEnXIi065747@repo.freebsd.org> <1660421447413365@web19h.yandex.ru> <56464A90.2040405@FreeBSD.org> <56464CBA.7060206@FreeBSD.org> <CCAE1243-3DC1-4077-BC55-AA6EA7750181@netflix.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 11/13/2015 1:00 PM, Randall Stewart wrote: > Bryan: > > This looks like a decent thing to do.. > > Still wondering why changing the callout.h header file would not have caused > things to recompile to pick up the new argument.. > > We can do it this way though it looks fine. > > You want to commit it or I? Well your change is totally safe for compiling. It's just not KBI backwards compat for older modules. This is not typically a problem but I think in this case it is worth doing to avoid random data coming into the 'drain' argument if loading an older module. I'll do a test build and commit it. Perhaps this is what was leading to Alexander's panics. I haven't analyzed the return value issue at all. -- Regards, Bryan Drewery [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWRlADAAoJEDXXcbtuRpfPnb4IANfTG0cl9GOtj5vhJEmsfyKs y9aqkIaAEvw/ApUp9X79crEjDguThTws+jultOyLel/O+moJ5edcV8Puqsbw5V+U +L9RCslkU4wxnChBJ09069iI2hcrAlxBvryQP8iQXDjus4t5DVYwawP2vPKNkidA fg8j5kgGLmR/6vtVWGv27gVsvqUEdIRvDIW6aGQq2wCzj99KKZE1KUa0IQYJztb5 J4E8FTAhl9VbbsPbUNiNt1p3qsuiFQQ/YpXuGtn4gjcCrU7IoxiStabymUtCI4Ad LMb/24/TWG+USGcqII5k2eh6J8zUWtKPmerL9mM1eIzNLVsPTZyPHJFjtlbDXvw= =et0M -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56465003.8070709>