Date: Wed, 29 Apr 2015 12:11:13 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: Garrett Cooper <ngie@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282211 - head/tests/freebsd_test_suite Message-ID: <068339F0-E6F0-4D10-B35D-AB4929521371@gmail.com> In-Reply-To: <20150429112944.GI546@FreeBSD.org> References: <201504290856.t3T8uuHF070908@svn.freebsd.org> <20150429112944.GI546@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_C5515D5E-6900-4BF0-BC59-F9F39EEA1B00 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Apr 29, 2015, at 4:29, Gleb Smirnoff <glebius@FreeBSD.org> wrote: > On Wed, Apr 29, 2015 at 08:56:56AM +0000, Garrett Cooper wrote: > G> Author: ngie > G> Date: Wed Apr 29 08:56:56 2015 > G> New Revision: 282211 > G> URL: https://svnweb.freebsd.org/changeset/base/282211 > G> > G> Log: > G> ATF_REQUIRE_KERNEL_MODULE: use atf_skip, not ATF_REQUIRE_MSG so = the testcase > G> no longer bombs out > G> PLAIN_REQUIRE_KERNEL_MODULE: use printf + _exit, no err so the = testcase no > G> longer bombs out if it prints to stderr > G> > G> MFC after: 5 days >=20 > This breaks buildworld since atf_skip() is a shell function, not a C = one: >=20 > glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-c > glebius@behemoth:/usr/src/head/contrib/atf:|>grep -r atf_skip atf-sh/ > atf-sh/atf-sh.3:.Nm atf_skip , Yeah. I should really stop committing things after midnight and should = have gotten CRs/produced tests which would have proved that my code was = broken twice :(. Fixed in r282244.. --Apple-Mail=_C5515D5E-6900-4BF0-BC59-F9F39EEA1B00 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVQSzSAAoJEMZr5QU6S73e9t8H/1Xk9ERJIPpR+g/TZ9zpUhpW pExsXPGM3qwH67kSTQ6RS6ic7gPsfJBvNruX+gqfT5jeHVMfJDtgHlQ9pPzJjYu/ Jwqlo9ttPT7spiXd/KGnhaYk7w2TaYV8sEPpZRD2xIYddTokSBkFF6+WvpHn1Ted k8jCUJBb1t2/Twcbn9C+Ck5x2aa9Ir5FmMhGga8oLB48VB5dnXKUwF3ZX91+P1ts MGJP5MsOiPpx0L5AJR/MdRxbjqGB1brxXE1JkL0ZLOXKitYkj4wuuJC8n0fHCUGV OdO+74WXLeilNKGMZABjgR5W1ytcNOyy6H6rKoFvTcng8V4lGbLxOsmQLtvA/Vg= =Yp4W -----END PGP SIGNATURE----- --Apple-Mail=_C5515D5E-6900-4BF0-BC59-F9F39EEA1B00--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?068339F0-E6F0-4D10-B35D-AB4929521371>