Date: Fri, 20 Nov 2020 14:37:08 +0000 (UTC) From: Mateusz Piotrowski <0mp@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r367893 - head/libexec/rc/rc.d Message-ID: <202011201437.0AKEb8r0007674@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: 0mp (doc,ports committer) Date: Fri Nov 20 14:37:07 2020 New Revision: 367893 URL: https://svnweb.freebsd.org/changeset/base/367893 Log: Revert r367291 (KEYWORD: shutdown for rc.d/zfs) The problem is that zfs is asked to stop too early in the shutdown sequence. Other services, such as syslog may still be running and have some files open (e.g., under /var/log). This of course causes the messages like: cannot unmount '/var/run': umount failed cannot unmount '/var/log': umount failed cannot unmount '/var': umount failed cannot unmount '/usr/home': umount failed cannot unmount '/usr': umount failed cannot unmount '/': umount failed For now, let's remove the shutdown KEYWORD from the zfs service, as people are reporting problems in their setups: https://lists.freebsd.org/pipermail/freebsd-current/2020-November/077559.html In the future, we may think of stopping zfs on shutdown after all the other services and just before init(8) exits. Another interesting option might be to a new rcorder(8) KEYWORD like "shutdownjail", but this idea would need to be discussed a bit. Reported by: Johan Hendriks <joh.hendriks gmail.com> Reported by: Yasuhiro KIMURA <yasu utahime.org> Reported by: Tomoaki AOKI <junchoon dec.sakura.ne.jp> Approved by: kevans (src) MFC: 3 days Differential Revision: https://reviews.freebsd.org/D27263 Modified: head/libexec/rc/rc.d/zfs Modified: head/libexec/rc/rc.d/zfs ============================================================================== --- head/libexec/rc/rc.d/zfs Fri Nov 20 14:02:43 2020 (r367892) +++ head/libexec/rc/rc.d/zfs Fri Nov 20 14:37:07 2020 (r367893) @@ -6,7 +6,6 @@ # PROVIDE: zfs # REQUIRE: zfsbe # BEFORE: FILESYSTEMS var -# KEYWORD: shutdown . /etc/rc.subr
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202011201437.0AKEb8r0007674>