Date: Fri, 5 Apr 2019 13:22:12 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: cem@freebsd.org Cc: Ed Maste <emaste@freebsd.org>, Xin LI <delphij@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r345900 - head/sbin/fsck_msdosfs Message-ID: <201904052022.x35KMCo0041093@gndrsh.dnsmgr.net> In-Reply-To: <CAG6CVpXyLGNmhH-QMjOsLmrvsD5LO1cnk%2BhVqrG5pYa5F=U2Rg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, Apr 5, 2019 at 6:49 AM Ed Maste <emaste@freebsd.org> wrote:
> >
> > On Fri, 5 Apr 2019 at 00:49, Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote:
> > >
> >
> > > > +static const u_char dot_name[] = {
> > > > + '.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > > > +static const u_char dotdot_name[] = {
> > > > + '.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> > > > +
> >
> > They are all either '.' or ' ', the commas are just list separators.
> > IMO spaces after the commas would make it slightly easier to see.
>
> Would it make sense to just use the normal string syntax for char
> array assignment?
>
> static const u_char dot_name[11] = ". ";
> static const u_char dotdot_name[11] = ".. ";
>
> Seems more clear to me.
To try and end this thread, I already stated it was in review,
let me get a pointer to it, if you have comments please post
them there:
https://reviews.freebsd.org/D19829
--
Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904052022.x35KMCo0041093>