Date: Sat, 29 Jul 2000 11:11:25 -0700 From: "Justin C. Walker" <justin@apple.com> To: freebsd-net@freebsd.org Subject: Re: sub-optimal tcp_ouput() performance in the face of ENOBUFS Message-ID: <200007291810.LAA14583@scv2.apple.com>
next in thread | raw e-mail | index | archive | help
On Saturday, July 29, 2000, at 10:56 AM, Mike Silbersack wrote: > > On Sat, 29 Jul 2000, Justin C. Walker wrote: > > > On Friday, July 28, 2000, at 07:58 PM, Mike Silbersack wrote: > > > Hm, I was going to wager that some calling procedure was acting > > > differently depending on the return value of tcp_output, but since ENOBUFS > > > returns 0, and the error isn't checked anyway. > > > > Forgive my early-morning density, but I've read this sentence several > > times, and it just doesn't look right. Could you try again? I know > > there's value in it, but it isn't making it through. > > > > Regards, > > > > Justin > > In the case of ip_output returning ENOBUFS to tcp_output, tcp_output > returns 0, even though there's an error. (I guess if the ENOBUFS case was > handled properly, 0 would be correct. But for now, it's certainly an > error.) > > But tcp_output returning an error wouldn't matter anyway, since nothing > which calls tcp_output actually checks the return value. Thanks for the clarification. FWIW in our source (FB3.2-based), while a lot of calls are cast as (void), the returned error actually is checked in a number of places (tcp_usrreq.c). These eventually wander back into user space, I think. Regards, Justin Justin C. Walker, Curmudgeon-At-Large * Institute for General Semantics | Manager, CoreOS Networking | Men are from Earth. Apple Computer, Inc. | Women are from Earth. 2 Infinite Loop | Deal with it. Cupertino, CA 95014 | *------------------------------------------------------*------------------------------------* To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007291810.LAA14583>