Date: Mon, 03 Aug 2020 13:14:48 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 248454] Two sysctls in /sys/kern/subr_smp.c with identical description - suggestion enclosed Message-ID: <bug-248454-227@https.bugs.freebsd.org/bugzilla/>
index | next in thread | raw e-mail
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248454 Bug ID: 248454 Summary: Two sysctls in /sys/kern/subr_smp.c with identical description - suggestion enclosed Product: Base System Version: 12.1-STABLE Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: dewayne@heuristicsystems.com.au Would it be possible to modify the descriptions of /usr/src/sys/kern/subr_smp.c to more accurately reflect the meaning of the sysctls. As a suggestion on line 99 to read "Number of logical CPUs online" and line 107 to read "Number of physical CPUs online" per: Line 99 int smp_cpus = 1; /* how many cpu's running */ SYSCTL_INT(_kern_smp, OID_AUTO, cpus, CTLFLAG_RD|CTLFLAG_CAPRD, &smp_cpus, 0, "Number of CPUs online"); Line 107 int mp_ncores = -1; /* how many physical cores running */ SYSCTL_INT(_kern_smp, OID_AUTO, cores, CTLFLAG_RD|CTLFLAG_CAPRD, &mp_ncores, 0, "Number of CPUs online"); :) I'll leave hw.ncpu for another day ;) -- You are receiving this mail because: You are the assignee for the bug.help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-248454-227>