Date: Thu, 12 Aug 2004 00:56:02 +0200 From: Maxime Henrion <mux@freebsd.org> To: Julian Elischer <julian@elischer.org> Cc: current@freebsd.org Subject: Re: [Fwd: RFC.. defining __rangeof() in cdefs.h] Message-ID: <20040811225602.GN13608@elvis.mu.org> In-Reply-To: <411AA203.1020502@elischer.org> References: <411AA203.1020502@elischer.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer wrote: > Interresting.. not a single comment.. :-/ > > From: Julian Elischer <julian@elischer.org> > Date: Mon, 09 Aug 2004 14:40:37 -0700 > To: current@freebsd.org > Subject: RFC.. defining __rangeof() in cdefs.h > > I'm considdereing adding: > Index: sys/cdefs.h > =================================================================== > RCS file: /home/ncvs/src/sys/sys/cdefs.h,v > retrieving revision 1.83 > diff -u -r1.83 cdefs.h > --- sys/cdefs.h 28 Jul 2004 07:03:42 -0000 1.83 > +++ sys/cdefs.h 9 Aug 2004 21:36:41 -0000 > @@ -241,6 +241,8 @@ > * require it. > */ > #define __offsetof(type, field) ((size_t)(&((type *)0)->field)) > +#define __rangeof(type, start, end) \ > + (__offsetof(type, end) - __offsetof(type, start)) > > /* > * Compiler-dependent macros to declare that functions take printf-like > > > it is used in several places. most importantly in fork1() > > and it is defined in several files (*).. we should probably just have > one copy... > > > (*) in the form RANGEOF() but if we define it in cdefs.h I'd change that to > __rangeof() to match __offsetof() The patch looks fine to me, I think it should go in. :-) Cheers, Maxime
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040811225602.GN13608>