Date: Sun, 30 May 2004 19:51:20 +0700 From: Alexey Dokuchaev <danfe@nsu.ru> To: Pawel Jakub Dawidek <pjd@freebsd.org> Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ndis.c src/sys/dev/if_ndis if_ndis.c Message-ID: <20040530125120.GB89299@regency.nsu.ru> In-Reply-To: <20040530094627.GD12007@darkness.comp.waw.pl> References: <200405290641.i4T6fHhj002797@repoman.freebsd.org> <20040530094627.GD12007@darkness.comp.waw.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, May 30, 2004 at 11:46:27AM +0200, Pawel Jakub Dawidek wrote:
> On Fri, May 28, 2004 at 11:41:17PM -0700, Bill Paul wrote:
> [...]
> +> +static int
> +> +my_strcasecmp(s1, s2, len)
> +> + const char *s1;
> +> + const char *s2;
> +> + int len;
> +> +{
> +> + int i;
> +> +
> +> + for (i = 0; i < len; i++) {
> +> + if (toupper(s1[i]) != toupper(s2[i]))
> +> + return(1);
> +> + }
> +> +
> +> + return(0);
> +> +}
> +> +
>
> Could we move it to libkern? I want to use it too.
Couple of questions/comments:
* is the any difference whether to use toupper() vs. tolower() ?
* curly braces are probably not needed
* style(9) fix: space after `return' statement.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040530125120.GB89299>