Date: Sat, 5 Aug 2023 13:38:57 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: Ed Maste <emaste@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: dedc71fd3890 - main - libc: unsplit log message to to make it greppable in src Message-ID: <FE59780C-3D48-4BF0-B5DE-4DF6596AF270@FreeBSD.org> In-Reply-To: <DB58F159-80A0-4CC2-A9CF-0EDF93E4C318@freebsd.org> References: <202308050100.37510VDJ085555@gitrepo.freebsd.org> <DB58F159-80A0-4CC2-A9CF-0EDF93E4C318@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 5 Aug 2023, at 04:11, Jessica Clarke <jrtc27@freebsd.org> wrote: > > On 5 Aug 2023, at 02:00, Ed Maste <emaste@FreeBSD.org> wrote: >> >> The branch main has been updated by emaste: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=dedc71fd3890803a81047a0c480b95a327bd7214 >> >> commit dedc71fd3890803a81047a0c480b95a327bd7214 >> Author: Ed Maste <emaste@FreeBSD.org> >> AuthorDate: 2023-04-17 15:58:59 +0000 >> Commit: Ed Maste <emaste@FreeBSD.org> >> CommitDate: 2023-08-05 00:59:30 +0000 >> >> libc: unsplit log message to to make it greppable in src >> >> Also use __func__ rather than hardcoding the function name. This code >> now fits in 80 columns without splitting the log message. > > This doesn’t match the commit? Indeed, during the review I noted that __func__ would not expand to the expected value ("__cxa_thread_call_dtors"), so that part was actually removed. Now the effective result only unsplits the message line. I guess this is a case of Phabricator or arc making it difficult to adjust the commit message before 'landing'. -Dimitry [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZM400QAKCRCwXqMKLiCW o39JAJ9EbyMcsluqu4nIMybrzAHxfyCBDwCeKM0EwjhFmX3sIgmr1+fLVKNgGwg= =Q+rD -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FE59780C-3D48-4BF0-B5DE-4DF6596AF270>