Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 May 2001 23:24:23 -0600
From:      Warner Losh <imp@harmony.village.org>
To:        Dima Dorfman <dima@unixfreak.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/usr.sbin/kbdcontrol kbdcontrol.c 
Message-ID:  <200105270524.f4R5ONE52094@harmony.village.org>
In-Reply-To: Your message of "Sat, 26 May 2001 21:50:57 PDT." <20010527045057.A800E3E30@bazooka.unixfreak.org> 
References:  <20010527045057.A800E3E30@bazooka.unixfreak.org>  

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20010527045057.A800E3E30@bazooka.unixfreak.org> Dima Dorfman writes:
: I agree that this is a better solution than what I committed, but I
: still think `kbdcontrol -L` should be factored out into another
: program.  It seems silly that kbdcontrol can't rely on up-to-date
: headers like most other programs in the system.

I think that's likely an excellent idea.  However, there are some
issues with this.  Some large number of items are defined in
sys/kbdio.h, which makes it hard to disentangle.  A kludge version can
be found at http://people.freebsd.org/~imp/kbddump.c.  It would be
better to make this something that could be built into kbdcontrol, or
built stand alone on a host to generate the keyboard .h files.

: > Consider the following untested patch:
: 
: If we can't/won't factor out `kbdcontrol -L`, I'll commit this.
: Thanks!  I knew there had to be a better way than defining an ioctl in
: the userland :-).

I'd commit this right away while people bikeshed the kbdcontrol :-)

Warner

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105270524.f4R5ONE52094>