Date: Mon, 10 Mar 2025 13:02:32 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: John Baldwin <jhb@FreeBSD.org>, Ravi Pokala <rpokala@freebsd.org>, <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org> Subject: Re: 78cd83e4017b - main - devclass_alloc_unit: Go back to using M_WAITOK Message-ID: <6DC2BB95-68EC-4710-AD36-7082FD52DC1A@panasas.com> In-Reply-To: <3ffc904b-7a14-412e-bf08-4703b00e3ffb@FreeBSD.org> References: <202503101735.52AHZiu6027210@gitrepo.freebsd.org> <14C8991D-C686-48DC-9E5D-5F40CE1C75BB@panasas.com> <3ffc904b-7a14-412e-bf08-4703b00e3ffb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Ah, I see. <mutters something about non- sortable commit IDs making "earlier" difficul= t to ascertain; sighs in futility> Thanks, Ravi (rpokala@) =EF=BB=BF-----Original Message----- From: John Baldwin <jhb@FreeBSD.org <mailto:jhb@FreeBSD.org>> Date: Monday, March 10, 2025 at 11:15 To: Ravi Pokala <rpokala@freebsd.org <mailto:rpokala@freebsd.org>>, <src-co= mmitters@FreeBSD.org <mailto:src-committers@FreeBSD.org>>, <dev-commits-src-= all@FreeBSD.org <mailto:dev-commits-src-all@FreeBSD.org>>, <dev-commits-src-= main@FreeBSD.org <mailto:dev-commits-src-main@FreeBSD.org>> Subject: Re: git: 78cd83e4017b - main - devclass_alloc_unit: Go back to usi= ng M_WAITOK On 3/10/25 13:41, Ravi Pokala wrote: > Hi John, >=20 >> This reverts commit 234683726708cf5212d672d676d30056d4133859. >=20 > The commit message for that change says that this allocation might be don= e while holding a lock, and so M_WAITOK is not valid. So then why is this ch= ange okay? >=20 > Thanks, Because the earlier commit to sdhci in this same push fixed it to create de= vices in a sleepable context. --=20 John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6DC2BB95-68EC-4710-AD36-7082FD52DC1A>