Date: Sat, 28 Oct 2017 16:49:26 -0700 From: Conrad Meyer <cem@freebsd.org> To: Mariusz Zaborski <oshogbo@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_g... Message-ID: <CAG6CVpWTDRYodBBimiOZLgHNpVbZPbm7hVakAh85Dh7TgZFdYQ@mail.gmail.com> In-Reply-To: <201710281923.v9SJNvE5021346@repo.freebsd.org> References: <201710281923.v9SJNvE5021346@repo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
Hi, On Sat, Oct 28, 2017 at 12:23 PM, Mariusz Zaborski <oshogbo@freebsd.org> wrote: > Author: oshogbo > Date: Sat Oct 28 19:23:57 2017 > New Revision: 325062 > URL: https://svnweb.freebsd.org/changeset/base/325062 > > Log: > Introduce caspermocks. > > The idea behinds mocks is that we don't need to ifdef a lot of code in > tools itself but those defines are hidden in the casper library. > Right now the mocks are implemented as define/inlines functions. > There was a very long discussion how this should be implemented. > This approach has some advantages like we don't need to link to any additional > libraries. Unfortunately there are also some disadvantages for example it is > easy to get library out of sync between two versions of functions or that we > need extra define to compile program with casper support. > This isn't an ideal solution but it's good enough for now and should simplify > capsicumizing programs. This also doesn't close us any other ways to do those > mocks and this should evolve in time. > > Discussed with: pjd, emaste, ed, rwatson, bapt, cem, bdrewery > Differential Revision: https://reviews.freebsd.org/D8753 It's worth pointing out "discussed with" here very much does not mean "approved by" — several of the people mentioned above raised concerns with this approach and only one person explicitly supported the change. Best, Conradhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWTDRYodBBimiOZLgHNpVbZPbm7hVakAh85Dh7TgZFdYQ>