Date: Tue, 25 Dec 2012 08:38:54 +0100 From: Luigi Rizzo <rizzo@iet.unipi.it> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r244665 - head/sys/netinet Message-ID: <20121225073854.GA16201@onelab2.iet.unipi.it> In-Reply-To: <201212242135.qBOLZnF8085020@svn.freebsd.org> References: <201212242135.qBOLZnF8085020@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 24, 2012 at 09:35:49PM +0000, Gleb Smirnoff wrote: > Author: glebius > Date: Mon Dec 24 21:35:48 2012 > New Revision: 244665 > URL: http://svnweb.freebsd.org/changeset/base/244665 > > Log: > Minor style(9) changes: > - Remove declaration in initializer. i am really curious, what is the point of removing one initialization out of three ? (and if anything, the 'register' should have gone...) cheers luigi > - Add empty line between logical blocks. > > Modified: > head/sys/netinet/in.c > > Modified: head/sys/netinet/in.c > ============================================================================== > --- head/sys/netinet/in.c Mon Dec 24 20:33:37 2012 (r244664) > +++ head/sys/netinet/in.c Mon Dec 24 21:35:48 2012 (r244665) > @@ -799,7 +799,7 @@ in_ifinit(struct ifnet *ifp, struct in_i > int masksupplied, int vhid) > { > register u_long i = ntohl(sin->sin_addr.s_addr); > - int flags = RTF_UP, error = 0; > + int flags, error = 0; > > IN_IFADDR_WLOCK(); > if (ia->ia_addr.sin_family == AF_INET) > @@ -843,9 +843,11 @@ in_ifinit(struct ifnet *ifp, struct in_i > } > ia->ia_subnet = i & ia->ia_subnetmask; > in_socktrim(&ia->ia_sockmask); > + > /* > * Add route for the network. > */ > + flags = RTF_UP; > ia->ia_ifa.ifa_metric = ifp->if_metric; > if (ifp->if_flags & IFF_BROADCAST) { > if (ia->ia_subnetmask == IN_RFC3021_MASK)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121225073854.GA16201>